Repository navigation
Update Retention Playwright tests to use real Synapse config endpoint - #33906
Merged
Merged
Conversation
dbkr
approved these changes
Jun 19, 2026
dbkr
left a comment
dbkr
left a comment
Member
There was a problem hiding this comment.
Nice, although your CI is very angry looking.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the change to use the newly minted element-hq/synapse#19853 endpoint rather than mocking it in Playwright, which hopefully means we're actually testing the full product.
This also adapts the SynapseConfig to have a distinct type, as it feels nicer than making optional config options a
key: undefined as ....Checklist
public/exportedsymbols have accurate TSDoc documentation.