Skip to content

Fix flakey e2e test: should select the next unread room - - #30634

Merged
langleyd merged 1 commit into
developfrom
langleyd/deflake-select-next-unread
Aug 27, 2025
Merged

langleyd merged 1 commit into
developfrom
langleyd/deflake-select-next-unread

Conversation

@langleyd

Copy link
Copy Markdown
Member

Fixes #29875

Wait for unread room to display before focusing it with the keyboard

@langleyd langleyd added the T-Task Tasks for the team like planning label Aug 27, 2025
@langleyd
langleyd marked this pull request as ready for review August 27, 2025 11:48
@langleyd
langleyd requested a review from a team as a code owner August 27, 2025 11:48
@langleyd
langleyd requested review from MidhunSureshR and dbkr August 27, 2025 11:48

@dbkr dbkr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although the other tests here are still failing on the first run and the succeeding on the second, so these look flaky too.

@langleyd

Copy link
Copy Markdown
Member Author

👍 Those other room list ones should be handled by #30633

@langleyd
langleyd added this pull request to the merge queue Aug 27, 2025
Merged via the queue into develop with commit a1f56eb Aug 27, 2025
45 of 46 checks passed
@langleyd
langleyd deleted the langleyd/deflake-select-next-unread branch August 27, 2025 13:34
Dileep9999 pushed a commit to hemanth-nag/element-web that referenced this pull request Oct 8, 2025

This branch was successfully deployed

2 active deployments
EndToEndTests — 846ff0bf Deployed Aug 27, 2025 by github-actions[bot]
Netlify — 846ff0bf Deployed Aug 27, 2025 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky playwright test: left-panel/room-list-panel/room-list.spec.ts: should select the next unread room

2 participants