Fix issue with duplicate images - #30073
Merged
t3chguy merged 3 commits intoJun 4, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29079.
I've added a method on the Exporter class to track duplicate file names and append an incrementing number to the duplicates, e.g.:
I've also added a test for this feature to the
HTMLExporttest suite, as that was the area in which the issue was discovered. While adding this test I found that the mock forcreateMessagesRequestwasn't resolving the correct value, which meant that tests were duplicating events, so I've corrected that (I'm a bit surprised this wasn't discovered before).Checklist
New or updated(N/A)public/exportedsymbols have accurate TSDoc documentation.