Skip to content

Global configuration flag for media previews - #29582

Merged
Half-Shot merged 63 commits into
developfrom
hs/media-previews-server-config
Apr 22, 2025
Merged

Half-Shot merged 63 commits into
developfrom
hs/media-previews-server-config

Conversation

@Half-Shot

@Half-Shot Half-Shot commented Mar 24, 2025 •

Copy link
Copy Markdown
Member

This implements MSC4155
Figma

This feature adds support for an account-level setting for configuring your own safety levels when browsing rooms. We already have support for configuring media previews on a per-device level but this allows the configuration to be expressed cross-device / client.

While not explicitly implemented, this also allows for servers to express defaults for their users (by setting default account data, if the server supports it).

Global setting

image

Room setting

image

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@amshakal

Copy link
Copy Markdown
Member

Looks fine to me but the spacing seems a bit off between:

  1. The title and subheading in 'Show media in timeline' section
  2. The spacing between different radio button options

@Half-Shot

Copy link
Copy Markdown
Member Author

Looks fine to me but the spacing seems a bit off between:

1. The title and subheading in 'Show media in timeline' section

2. The spacing between different radio button options

image

How's this @amshakal ?

@amshakal

Copy link
Copy Markdown
Member

That's better! :) TY!

Comment thread res/css/views/settings/tabs/user/_MediaPreviewAccountSettings.pcss
Comment thread src/HtmlUtils.tsx

This branch was successfully deployed

2 active deployments
EndToEndTests — 1efe4b5c Deployed Apr 22, 2025 by github-actions[bot]
Netlify — 1efe4b5c Deployed Apr 22, 2025 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants