Add Advanced section to the user settings encryption tab - #28804
Merged
Merged
Conversation
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
December 23, 2024 14:57
5055c46 to
85ce1cc
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
December 23, 2024 15:24
85ce1cc to
32ec0d2
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
December 24, 2024 15:20
32ec0d2 to
6467943
Compare
This was referenced Jan 6, 2025
florianduros
force-pushed
the
florianduros/advanced-section
branch
2 times, most recently
from
January 8, 2025 13:46
a8dd23c to
00a85d8
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
January 9, 2025 14:51
380ef62 to
8bd5d6a
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
January 13, 2025 09:31
00a85d8 to
a2a2512
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
January 15, 2025 14:03
9841d92 to
fd51450
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
January 15, 2025 16:10
fd51450 to
8f98a63
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
January 16, 2025 14:54
8f98a63 to
58d2f91
Compare
- Remove generic type
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
January 22, 2025 13:55
a389417 to
df4cec1
Compare
florianduros
force-pushed
the
florianduros/advanced-section
branch
from
January 22, 2025 14:52
74c9a7b to
7ddd021
Compare
florianduros
added
the
X-Run-All-Tests
florianduros
marked this pull request as ready for review
January 22, 2025 15:28
dbkr
approved these changes
Jan 22, 2025
uhoreg
approved these changes
Jan 24, 2025
uhoreg
left a comment
uhoreg
left a comment
Member
There was a problem hiding this comment.
From a crypto standpoint, looks sane. There's a wording thing that I'm not completely happy with, but it may be good enough.
| "breadcrumb_first_description": "Your account details, contacts, preferences, and chat list will be kept", | ||
| "breadcrumb_page": "Reset encryption", | ||
| "breadcrumb_second_description": "You will lose any message history that’s stored only on the server", | ||
| "breadcrumb_third_description": "You will need to verify all your existing devices and contacts again", |
Member
There was a problem hiding this comment.
I think this could be a bit misleading, as it says that the user needs to verify all their contacts, whereas they really only need to re-verify contacts that they had already verified. Though I don't know how to word it better without being overly wordy. So maybe it's OK.
This was referenced Oct 6, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task #26468
Closes #28977
Required matrix-org/matrix-js-sdk#4614
Figma design
Add a new section to the encryption tab of the user settings. This section adds: