Fix code block highlighting not working reliably with many code blocks - #28613
Merged
Merged
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
florianduros
approved these changes
Dec 2, 2024
dbkr
approved these changes
Dec 2, 2024
This was referenced Oct 6, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28607
The issue was the pres list was mutating itself and thus the for loop only hit every other pre.
There was an additional issue in React dev mode which meant that some highlighting was never done due to the double-rendering debug that React does causing the CodeBlock components to unmount but never clean up after themselves ready for a re-mount