Skip to content

New UX for Share dialog - #28598

Merged
florianduros merged 6 commits into
developfrom
florianduros/new-share-dialog
Dec 2, 2024
Merged

florianduros merged 6 commits into
developfrom
florianduros/new-share-dialog

Conversation

@florianduros

@florianduros florianduros commented Nov 29, 2024 •

Copy link
Copy Markdown
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task https://github.com/element-hq/customer-success/issues/408
Figma design
The quick (social) buttons are not yet implemented in compound web, I used the previous icons of the share dialog. Theses buttons will be replaced when implemented (soon).

Before After
image image image

Comment thread src/components/views/context_menus/MessageContextMenu.tsx Outdated
@florianduros
florianduros marked this pull request as ready for review December 2, 2024 16:55
@florianduros
florianduros requested a review from a team as a code owner December 2, 2024 16:55
@florianduros
florianduros requested review from dbkr and t3chguy December 2, 2024 16:55
@florianduros florianduros changed the title New UX for ShareDialog New UX for Share dialog Dec 2, 2024
Comment thread playwright/e2e/share-dialog/index.ts Outdated
Comment thread playwright/e2e/share-dialog/share-dialog.spec.ts Outdated
Comment thread res/css/views/dialogs/_ShareDialog.pcss Outdated
@florianduros
florianduros requested a review from t3chguy December 2, 2024 18:05
@florianduros
florianduros added this pull request to the merge queue Dec 2, 2024
Merged via the queue into develop with commit 0429809 Dec 2, 2024
@florianduros
florianduros deleted the florianduros/new-share-dialog branch December 2, 2024 18:27

This branch was successfully deployed

2 active deployments
EndToEndTests — f098261c Deployed Dec 2, 2024 by github-actions[bot]
Netlify — f098261c Deployed Dec 2, 2024 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants