Skip to content

Remove Features.RustCrypto flag - #28582

Merged
florianduros merged 2 commits into
developfrom
florianduros/remove-rust-crypto-flag
Nov 27, 2024
Merged

florianduros merged 2 commits into
developfrom
florianduros/remove-rust-crypto-flag

Conversation

@florianduros

Copy link
Copy Markdown
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@florianduros
florianduros force-pushed the florianduros/remove-rust-crypto-flag branch from ef271ba to 888f762 Compare November 27, 2024 14:57
@florianduros
florianduros force-pushed the florianduros/remove-rust-crypto-flag branch from 888f762 to 4fe9486 Compare November 27, 2024 15:06

@t3chguy t3chguy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could of tests still reference feature_rust_crypto

@florianduros

Copy link
Copy Markdown
Member Author

@t3chguy I removed the check of feature_rust_crypto

@florianduros
florianduros marked this pull request as ready for review November 27, 2024 15:18
@florianduros
florianduros requested a review from a team as a code owner November 27, 2024 15:18
@florianduros
florianduros added this pull request to the merge queue Nov 27, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024

This branch was successfully deployed

2 active deployments
EndToEndTests — df11e6ab Deployed Nov 27, 2024 by github-actions[bot]
Netlify — df11e6ab Deployed Nov 27, 2024 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants