Skip to content

Default avatar url and colors should be skinnable #8697

Closed

Description

@abeluck

Since the default avatar urls are images, not css, they cannot be changed by a skin/theme.

ref: https://github.com/matrix-org/matrix-react-sdk/blob/master/src/Avatar.js#L53-L60

In #7569 it was mentioned removing the images and replacing them with background colors. This seems like a good idea. I think that issue got lost/ignored since #8474.

Activity

  1. jryans commented on Feb 15, 2019

    @jryans
    Collaborator

    Yes, I agree we should change to CSS for these. It's a bit silly to use images here.

  2. added
    S-MinorImpairs non-critical functionality or suitable workarounds exist
    on Feb 15, 2019
  3. bl1mp commented on Oct 1, 2019

    @bl1mp

    indeed

  4. fooness commented on Apr 12, 2020

    @fooness
    Contributor

    It also would be great to define config.json css variables in light-custom/css/_custom.css to be able to customize the avatar background AND foreground color …

  5. robintown commented on Jul 16, 2021

    @robintown
    Member
  6. added a commit that references this issue on Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-AvatarP3S-MinorImpairs non-critical functionality or suitable workarounds existT-Defect

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions