Skip to content

Can't verify messages whose keys were forwarded #8470

Closed

Description

@dbkr

We currently never show messages whose keys have been forwarded from another device as validated, even if we've verified all the devices in question, 'cos the js-sdk doesn't implement verification of the forwarding key chain: https://github.com/matrix-org/matrix-js-sdk/blob/master/src/crypto/index.js#L588

Activity

  1. lampholder commented on Feb 19, 2019

    @lampholder
    Member

    I can't quite fully reason through whether we'll need to fix this as part of our E2E UX push, or whether it will almost always not be a problem if all the other components (existing and pending) are doing their job properly. One to revisit later.

  2. added
    S-MajorSeverely degrades major functionality or product features, with no satisfactory workaround
    on Feb 19, 2019
  3. dbkr commented on Feb 27, 2019

    @dbkr
    MemberAuthor

    I think it depends whether we're relying on key sharing. If we're expecting key sharing to never normally be necessary then fixing this is not so important.

  4. ShadowJonathan commented on Dec 16, 2021

    @ShadowJonathan
    Contributor

    Messages that were forwarded from different devices currently show as (properly) verified on other devices, is this still applicable?

  5. kittykat commented on Dec 16, 2021

    @kittykat
    Contributor

    @dbkr I'm going to close this for now as it seems resolved, could you please re-open if it's still valid?

  6. added a commit that references this issue on Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions