PDFs no longer open reliably on Chrome #8116

Activity

1. lampholder commented on Jan 21, 2019

   

   lampholder

   on Jan 21, 2019

   Member

   More actions

   We thought we'd tested to verify that this wasn't the case, but obviously not.

   Now as I understand it it's basically a trade off - if we want .pdfs to open on Chrome, we need to run the risk of firefox being vulnerable to running js code that's been uploaded to the media repo.
2. lampholder

   added

   T-Defect

   P2

   S-MinorImpairs non-critical functionality or suitable workarounds existImpairs non-critical functionality or suitable workarounds exist

   on Jan 21, 2019
3. lampholder commented on Jan 21, 2019

   

   lampholder

   on Jan 21, 2019

   Member

   More actions

   We could look into mitigating this by setting the download content disposition on pdfs, perhaps from within Synapse, perhaps from Riot.
4. jryans commented on Jan 21, 2019

   

   jryans

   on Jan 21, 2019

   Collaborator

   More actions

   I guess another option would be to tailor the CSP based on browser UA, but I know that's pretty gross and frowned upon.
5. turt2live commented on Feb 13, 2019

   

   turt2live

   on Feb 13, 2019

   Member

   More actions

   Closing in favour of #8605 (higher priority)
6. turt2live

   closed this as completedon Feb 13, 2019