Flaky cypress test "Spotlight > should be able to add and remove filters via keyboard"

[andybalaam]

I got this failure: https://cloud.cypress.io/projects/ppvnzg/runs/17651/test-results/e1150166-7a80-4155-9428-76e9ec118440 when I was trying to merge a PR for an unrelated change.

Timed out retrying after 10000ms: expected '<li#mx_SpotlightDialog_button_explorePublicRooms.mx_AccessibleButton.mx_SpotlightDialog_explorePublicRooms.mx_SpotlightDialog_option>' to have attribute 'aria-selected' with the value 'true', but the value was 'false'

cypress/e2e/spotlight/spotlight.spec.ts at line154 

[andybalaam]

https://github.com/matrix-org/matrix-react-sdk/actions/runs/6069472488/job/16463907578

[andybalaam]

Spent some time trying to debug this. I ran it ~10 times locally and couldn't get it to happen, even with --browser=chromium

[andybalaam]

Ah, after another few tries it did happen.

[andybalaam]

The failure was on the SECOND time it asserted that aria-selected==true

[andybalaam]

I added a longer timeout and left this running over and over in the hope that I can get it to fail and stick in the failing state.

[andybalaam]

The "Explore Public Spaces" option is selected and we are expecting "Explore Public Rooms" to be.

[andybalaam]