"Show All" link button on ReactionsRow should be styled properly #22300

Activity

1. luixxiul

   added

   T-Defect

   on May 20, 2022
2. luixxiul

   changed the title [-]"Show All" link button should be styled properly[/-] [+]"Show All" link button on ReactionsRow should be styled properly[/+] on May 20, 2022
3. SimonBrandner

   added

   X-Needs-Design

   on May 20, 2022
4. SimonBrandner commented on May 20, 2022

   

   SimonBrandner

   on May 20, 2022

   Contributor

   More actions

   I think I actually prefer the green one, @vector-im/design, what do you think off this?
5. SimonBrandner

   added

   S-MinorImpairs non-critical functionality or suitable workarounds existImpairs non-critical functionality or suitable workarounds exist

   A-Reactions

   O-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceAffects or can be seen by most users regularly or impacts most users' first experience

   on May 20, 2022
6. luixxiul commented on May 20, 2022

   

   luixxiul

   on May 20, 2022

   Last edited by luixxiul

   Author

   More actions

   It could be easily realized by removing this line: https://github.com/matrix-org/matrix-react-sdk/pull/8658/files#diff-9b841ae6013a222403aff59b3ae7d1c76c11a381b24a749607bfeff22dc07c8dR65.

   The main issue here is that current implementation does not respect declarations of .mx_ReactionsRow_showAll block and all of them except the margin declaration are not effective.

   👍React with 👍1Reacted by Šimon Brandner
7. SimonBrandner commented on May 20, 2022

   

   SimonBrandner

   on May 20, 2022

   Contributor

   More actions

   It could be easily realized by removing this line: matrix-org/matrix-react-sdk#8658 (files).

   The main issue here is that current implementation does not respect declarations of .mx_ReactionsRow_showAll block and all of them except the margin declaration are not effective.

   Could we split this into two things - the color and the rest?
8. luixxiul commented on May 20, 2022

   

   luixxiul

   on May 20, 2022

   Last edited by luixxiul

   Author

   More actions

   Since #8658 does not change the current color value, it is possible to do so by moving the color declaration for link color directly under mx_ReactionsRow_showAll, though I am sure it is not a great way as it has the color property overridden on purpose 😅

   As below:

   .mx_ReactionsRow_showAll {
       color: $tertiary-content;
   
       &.mx_AccessibleButton_kind_link_inline {
           font-size: $font-12px;
           line-height: $font-20px;
           margin-inline-start: $spacing-4;
           vertical-align: middle;
   
           &:hover {
               color: $primary-content;
           }
       }
   }
   

   Otherwise the color declaration can be commented out, which might be more proper.
9. SimonBrandner

   closed this as completedin matrix-org/matrix-react-sdk#8658on May 21, 2022
10. su-ex

    added 3 commits that reference this issue on Jun 7, 2022

    Merge tag 'v1.10.14' into sc

    ...

    This issue will close once commit bb2a41e is merged into the 'sc' branch.

    bb2a41e

    Merge tag 'v1.10.14' into sc

    ...

    This issue will close once commit 4b5042b is merged into the 'sc' branch.

    4b5042b

    Merge tag 'v3.46.0' into sc

    ...

    This issue will close once commit 56703ed is merged into the 'sc' branch.

    56703ed