Search highlighting breaks links

[fabianunterstell]

Description

Search highlighting breaks links in reply messages

Steps to reproduce

1. Send a message with a link for example: https://github.com/vector-im/element-web.
2. Reply anything to the link message.
3. Search for the message with the link for example with the keyword web.
4. Click the link.
5. The opened link does not include the part web highlighted by the search: https://github.com/vector-im/element- and is broken.

• I found this bug only in reply messages but did not do an extensive search. It might happen elsewhere too.

Version information

• Platform: web (in-browser) or desktop?
  Windows 10 desktop

• For the desktop app:
  Element version: 1.7.25
  olm version: 3.2.1

[fabianunterstell]

Side note:
switching to another account to report this bug triggered this issue as well and I needed to remove the EventStore folder to be able to use the search function in the first place.

[SimonBrandner]

Side note:
switching to another account to report this bug triggered this issue as well and I needed to remove the EventStore folder to be able to use the search function in the first place.

Could you open a new issue for that, please?

[fabianunterstell]

Side note:
switching to another account to report this bug triggered this issue as well and I needed to remove the EventStore folder to be able to use the search function in the first place.

Could you open a new issue for that, please?

Here is the new issue:
#17045

[HarHarLinks]

I can repro in Element Nightly version: 2022101301
Olm version: 3.2.12

[t3chguy]

@HarHarLinks can you share a screenshot? I can't reproduce highlighting on the replies

[HarHarLinks]

I can repro in Element Nightly version: 2022101301 Olm version: 3.2.12

sorry, this is slightly inaccurate. here is what happens to me:

i.e. the reply found in the search is fine, but the link in the original message in search results is broken.

this is also within an encrypted room (DM on element-desktop with crypto search enabled) Element Nightly version: 2022101901
Olm version: 3.2.12

[t3chguy]

Linkification happens after highlighting, which is backwards, affects both html & plain messages

[dbkr]

I just ran into this too and can confirm it's not specific to replies. Search for anything that's part of a link, eg. 'web' as above in "https://github.com/vector-im/element-web". The search highlight puts a highlight span around the 'web' but then it adds another a tag (still inside the old one) for the rest of the link.

[ara4n]

(similar to but not the same as #29807)