starting a VC with 2 people + a invitee can result in very strange race conditions

[ara4n]

Starting a voice/video conference (VC) with 2 people + a invitee can result in very strange race conditions.

Reproduction instructions

1. have a room with 2 people (A,B) + invitee (C)
2. user A hits video call button - starts 1:1 with B
3. C joins the room
4. user C starts a voice/video conference
5. all hell breaks loose, with Voip Conference users appearing in the memberlist and all sorts.

[SimonBrandner]

The simple solution here would probably be to just start a conference if we have invitees

[kittykat]

The correct approach would be to check if the room is not a DM and if it is not, then start a conference call instead of a 1:1 call

[SimonBrandner]

The correct approach would be to check if the room is not a DM and if it is not, then start a conference call instead of a 1:1 call

I would argue that we should just check the member + invite count. Making this dependent on whether the room is a DM or not seems a little unideal. Both because people have DMs with more than 2 members and because this can break at times

[kittykat]

The correct approach would be to check if the room is not a DM and if it is not, then start a conference call instead of a 1:1 call

I would argue that we should just check the member + invite count. Making this dependent on whether the room is a DM or not seems a little unideal. Both because people have DMs with more than 2 members and because this can break at times

That would work unless a call is already in progress. Good point about DMs having more than two members. Can we do a check on "if room is not a DM or a DM and has 3+ members"? I defer to @dbkr to check the logic.