Replace matrix-js-sdk's MatrixEvent with our own representation - #34
Merged
Merged
Conversation
4 tasks done
Half-Shot
requested review from
t3chguy
and removed request for
MidhunSureshR and
dbkr
June 17, 2025 12:38
Member
Author
|
(assigning @t3chguy as I think it's probably better to reduce context switching this one) |
Member
|
Might be worth consulting semver definitions for whether this needs to be a major version bump due to the breaking change |
t3chguy
approved these changes
Jun 17, 2025
Member
Author
|
Based on https://semver.org/, it would be a major since this is backwards incompatible. We're removing a lot of properties, and even the ones that remain are effectively renamed ( |
Member
|
Keep in mind that doing so will break all existing modules when being used with an updated Element Web, this is why we need to more careful. Is there anything in semver which says we can avoid this due to it being beta? I guess not because of the warning So the API method was public |
t3chguy
reviewed
Jun 17, 2025
Half-Shot
force-pushed
the
hs/modules-matrix-event
branch
from
June 17, 2025 13:07
ef26071 to
fc7fe00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaw in element-hq/element-web#30074 whereby due to differing imports of the matrix-js-sdk, it's not possible to (safely) pass the type from Element Web to a module. In line with us thinking about the future with Rust SDKs, this changes the module API to use it's own SDK neutral interface.
This is a backwards incompatible change. We are marking the Custom Message Components API as alpha stability due to the potential for further changes, and will adjust in the future.
Companion commit is element-hq/element-web@66e7381