Fix tap-to-show call controls on iOS#3966
Merged
Merged
Conversation
robintown
previously approved these changes
May 15, 2026
robintown
left a comment
Member
There was a problem hiding this comment.
This generally sounds fine as a fix. I will just test in a couple different browsers and layouts before approving.
We used to use a touchend rather than click handler for this, and that relied on a timer to determine whether the input was actually a tap rather than a long press. Now that I'm thinking about it again, I don't know why we should care that much about the press length. It might still make sense to listen for touchend rather than pointerup, for simplicity's sake, but also not a big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

iOS Safari doesn't reliably fire
clickon plain<div>s, so we listen forpointerupinstead. Scrolls end inpointercancel, notpointerup, so this still only fires for taps.