Skip to content

Fix tap-to-show call controls on iOS#3966

Merged
toger5 merged 1 commit into
livekitfrom
fkwp/fix-ios-tap-reveal-controls
May 19, 2026
Merged

Fix tap-to-show call controls on iOS#3966
toger5 merged 1 commit into
livekitfrom
fkwp/fix-ios-tap-reveal-controls

Conversation

@fkwp

@fkwp fkwp commented May 15, 2026

Copy link
Copy Markdown
Contributor

iOS Safari doesn't reliably fire click on plain <div>s, so we listen for pointerup instead. Scrolls end in pointercancel, not pointerup, so this still only fires for taps.

robintown
robintown previously approved these changes May 15, 2026

@robintown robintown left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally sounds fine as a fix. I will just test in a couple different browsers and layouts before approving.

We used to use a touchend rather than click handler for this, and that relied on a timer to determine whether the input was actually a tap rather than a long press. Now that I'm thinking about it again, I don't know why we should care that much about the press length. It might still make sense to listen for touchend rather than pointerup, for simplicity's sake, but also not a big deal.

@robintown robintown dismissed their stale review May 15, 2026 14:14

Oops, I meant to simply comment

@toger5 toger5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for a follow up discussion/PR:
We might also want to hide the controls on web if the window is very small:

Image

In this case the PointerUp event is helpful as it also allows to show/hide the controls on web.

For the same reason I approve merging with pointUp instead of touchEnd.

@toger5 toger5 merged commit 0e3aaaa into livekit May 19, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bug-Fix Release note category. A PR that fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants