chore(cli)!: remove --tmpdir=false flag#1834
Conversation
dsanders11
left a comment
There was a problem hiding this comment.
Unrelated note, but we should probably take this time to drop yargs-parser in favor of the Node.js built-in utils.parseArgs.
Is there any breaking behaviour you envision for a refactor like that? I'm okay with saving it for a minor release of v19 if it's transparent to the user. One other alternative we might want to consider is to lean the other way and switch to |
I'm not familiar enough with this codebase to know for sure, but I think from a quick glance it should be possible to do without a breaking change.
It looks like the CLI flags in this package are pretty simple, I don't think we need to complexity of |
|
🎉 This PR is included in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: removes
--tmpdir=falseoption in the CLI. Use--no-tmpdirinstead.Removing some old deprecated CLI code. Follows the usage docs that say to use
--no-tmpdir... but I took a look and it seems like--no-tmpdirisn't currently wired up inparseArgs? So I added it.