Skip to content

chore(cli)!: remove --tmpdir=false flag#1834

Merged
dsanders11 merged 1 commit into
mainfrom
tmpdir
Sep 19, 2025
Merged

chore(cli)!: remove --tmpdir=false flag#1834
dsanders11 merged 1 commit into
mainfrom
tmpdir

Conversation

@erickzhao

@erickzhao erickzhao commented Sep 18, 2025

Copy link
Copy Markdown
Member

BREAKING CHANGE: removes --tmpdir=false option in the CLI. Use --no-tmpdir instead.

Removing some old deprecated CLI code. Follows the usage docs that say to use --no-tmpdir... but I took a look and it seems like --no-tmpdir isn't currently wired up in parseArgs? So I added it.

@erickzhao erickzhao requested a review from a team as a code owner September 18, 2025 22:42
@erickzhao erickzhao requested a review from malept September 18, 2025 22:42

@dsanders11 dsanders11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated note, but we should probably take this time to drop yargs-parser in favor of the Node.js built-in utils.parseArgs.

@erickzhao

Copy link
Copy Markdown
Member Author

Unrelated note, but we should probably take this time to drop yargs-parser in favor of the Node.js built-in utils.parseArgs.

Is there any breaking behaviour you envision for a refactor like that? I'm okay with saving it for a minor release of v19 if it's transparent to the user.

One other alternative we might want to consider is to lean the other way and switch to commander (which is what Forge uses) to align packages.

@dsanders11

Copy link
Copy Markdown
Member

Is there any breaking behaviour you envision for a refactor like that? I'm okay with saving it for a minor release of v19 if it's transparent to the user.

I'm not familiar enough with this codebase to know for sure, but I think from a quick glance it should be possible to do without a breaking change.

One other alternative we might want to consider is to lean the other way and switch to commander (which is what Forge uses) to align packages.

It looks like the CLI flags in this package are pretty simple, I don't think we need to complexity of commander, but it looks like commander@^14 is zero dependency, so I'm not necessarily opposed. We can start with the built-in and switch to commander if complexity requires it.

@dsanders11 dsanders11 merged commit 0a60650 into main Sep 19, 2025
8 checks passed
@dsanders11 dsanders11 deleted the tmpdir branch September 19, 2025 05:33
@continuous-auth

Copy link
Copy Markdown

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants