feat!: default derefSymlinks to true#1829
Merged
Merged
Conversation
dsanders11
approved these changes
Sep 10, 2025
Member
|
Can we add |
|
🎉 This PR is included in version 19.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goosewobbler
added a commit
to webdriverio/desktop-mobile
that referenced
this pull request
May 29, 2026
…iles, not store symlinks ROOT CAUSE of the 'Could not find Electron app built with Electron Forge!' flake: @electron/packager@18.4.4 (the version forge 7.11 bundles) defaults derefSymlinks=false, so packaging a pnpm-installed app copies the symlinked node_modules (pointing into the store, outside the package) rather than the real files — a copy that fails flakily on CI filesystems (no binary produced), while happening to work on local macOS. @electron/packager v19 flips this default to true (electron/packager#1829); the option already exists in 18.4.4, so set derefSymlinks:true in both forge fixtures' packagerConfig to get the v19 behavior without a 2-major bump. Reverts the A/B direct-packager scaffolding on the cjs fixture. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: defaults to
derefSymlinks: trueif the value isn't explicitly defined.This PR also removes the second layer of logic that defaults this value via the CLI (instead specifying it in the core API).