Skip to content

fix: derefSymlinks not set default to true correctly#1654

Closed
ianho wants to merge 1 commit into
electron:mainfrom
ianho:patch-1
Closed

fix: derefSymlinks not set default to true correctly#1654
ianho wants to merge 1 commit into
electron:mainfrom
ianho:patch-1

Conversation

@ianho

@ianho ianho commented Jan 9, 2024

Copy link
Copy Markdown
  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@ianho ianho requested a review from a team as a code owner January 9, 2024 09:28
@welcome

welcome Bot commented Jan 9, 2024

Copy link
Copy Markdown

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@codecov

codecov Bot commented Jan 9, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.81%. Comparing base (aa6fd4c) to head (6470ac6).
⚠️ Report is 111 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   92.03%   91.81%   -0.23%     
==========================================
  Files          16       16              
  Lines         854      855       +1     
  Branches      167      168       +1     
==========================================
- Hits          786      785       -1     
- Misses         51       52       +1     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erikian erikian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add a regression test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants