fix: set Dirent.parentPath in asar fs.readdir withFileTypes - #52506
Merged
ckerr merged 1 commit intoJul 29, 2026
Conversation
The asar fs wrapper built Dirent objects with `new fs.Dirent(name, type)` in the non-recursive readdir handlers, which left `parentPath` undefined. As a result `Dirent.parentPath` was missing for `fs.readdir` / `readdirSync` (and for `fs.glob` / `globSync`, which read directories through these handlers) when operating inside an asar archive, while it was correctly populated outside of asar and on the recursive readdir code path. Use the internal `getDirent(path, name, type)` helper instead, matching both the recursive readdir path and Node's own behavior, so `parentPath` is set to the directory that was read. Fixes #51838 Co-authored-by: Sanidhya Singh <singhsanidhya741@gmail.com>
4 tasks
trop
Bot
added
42-x-y
backport
ckerr
approved these changes
Jul 29, 2026
ckerr
deleted the
trop/42-x-y-bp-fix-set-dirent-parentpath-in-asar-fs-readdir-withfiletypes-1785284706755
branch
July 29, 2026 02:19
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51845
See that PR for details.
Notes: Fixed
Dirent.parentPathbeingundefinedforfs.readdir,fs.readdirSync,fs.glob, andfs.globSyncwithwithFileTypes: trueinside asar archives.