Summary
verifier.live_validate classifies Elasticsearch's Cannot mix time-series aggregate … and regular aggregate … rejection as other. --fail-on-bug only exits non-zero on real_bug, so a translator bug of this class stays green.
Found while running the live-cluster Datadog/Grafana pass in #454. The mixed-STATS emitter itself is a separate Grafana concern (_normalize_mixed_ts_stats_exprs in promql.py); this issue is the gate that fails to count the rejection.
Where
parity-rig/verifier/live_validate.py
classify_error (other is the fallback after _DATA_GAP and _REAL_BUG)_REAL_BUG does not match this verification exceptionmain returns non-zero only when --fail-on-bug and summary["real_bugs"]
The module docstring defines other as "anything else (5xx, transport, timeouts)". A query Elasticsearch rejects because the emitted STATS mixes aggregate kinds is a translator bug, the same class as the parsing/type errors already in _REAL_BUG.
Expected
That error text classifies as real_bug, is printed with the other real bugs, and fails a --fail-on-bug run.
Parent
Sub-issue of https://github.com/elastic/obs-integration-team/issues/1203.
Summary
verifier.live_validateclassifies Elasticsearch'sCannot mix time-series aggregate … and regular aggregate …rejection asother.--fail-on-bugonly exits non-zero onreal_bug, so a translator bug of this class stays green.Found while running the live-cluster Datadog/Grafana pass in #454. The mixed-
STATSemitter itself is a separate Grafana concern (_normalize_mixed_ts_stats_exprsinpromql.py); this issue is the gate that fails to count the rejection.Where
parity-rig/verifier/live_validate.pyclassify_error(otheris the fallback after_DATA_GAPand_REAL_BUG)_REAL_BUGdoes not match this verification exceptionmainreturns non-zero only when--fail-on-bugandsummary["real_bugs"]The module docstring defines
otheras "anything else (5xx, transport, timeouts)". A query Elasticsearch rejects because the emittedSTATSmixes aggregate kinds is a translator bug, the same class as the parsing/type errors already in_REAL_BUG.Expected
That error text classifies as
real_bug, is printed with the other real bugs, and fails a--fail-on-bugrun.Parent
Sub-issue of https://github.com/elastic/obs-integration-team/issues/1203.