Skip to content

Add dimension field previously missed during package-spec v3 migration - #8260

Merged
tommyers-elastic merged 3 commits into
elastic:mainfrom
shmsr:migrate-infraobs-ps-v3-batch-1-serverless-bugfix
Oct 23, 2023
Merged

Add dimension field previously missed during package-spec v3 migration#8260
tommyers-elastic merged 3 commits into
elastic:mainfrom
shmsr:migrate-infraobs-ps-v3-batch-1-serverless-bugfix

Conversation

@shmsr

@shmsr shmsr commented Oct 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed commit message

Add dimension: true for a couple of packages (airflow and cockroachdb) which was previously missed in #8170 during package-spec v3 migration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@shmsr
shmsr requested a review from a team as a code owner October 22, 2023 03:59
@shmsr shmsr mentioned this pull request Oct 22, 2023
Closed
51 of 96 tasks
@elasticmachine

elasticmachine commented Oct 22, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-22T03:59:33.536+0000

  • Duration: 15 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Oct 22, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 50.0% (4/8) 👎 -42.35
Lines 100.0% (0/0) 💚 8.412
Conditionals 100.0% (0/0) 💚

@tommyers-elastic
tommyers-elastic merged commit 25849be into elastic:main Oct 23, 2023
@shmsr
shmsr deleted the migrate-infraobs-ps-v3-batch-1-serverless-bugfix branch October 23, 2023 08:43
@shmsr shmsr self-assigned this Oct 23, 2023
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@shmsr
Add dimension field previously missed during package-spec v3 migrat…
94374f3 
…ion (elastic#8260)

* Add dimension fields previously missed during package-spec v3 migration

* Add changelog entry for cockroachdb

* Add changelog entry for airflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@shmsr shmsr

Labels

Integration:airflow Airflow Integration:cockroachdb CockroachDB Metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shmsr @elasticmachine @tommyers-elastic @andrewkroh