Skip to content

cisco_asa: expand set of accepted auth rejection reasons and retain reason - #8015

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:7757-cisco_asa
Sep 29, 2023
Merged

cisco_asa: expand set of accepted auth rejection reasons and retain reason#8015
efd6 merged 1 commit into
elastic:mainfrom
efd6:7757-cisco_asa

Conversation

@efd6

@efd6 efd6 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Sep 29, 2023
@elasticmachine

elasticmachine commented Sep 29, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-29T01:06:39.401+0000

  • Duration: 18 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Sep 29, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 5.556
Classes 100.0% (1/1) 💚 5.556
Methods 94.444% (17/18) 👍 8.398
Lines 69.77% (1544/2213) 👎 -16.299
Conditionals 100.0% (0/0) 💚

@efd6
efd6 marked this pull request as ready for review September 29, 2023 01:05
@efd6
efd6 requested a review from a team as a code owner September 29, 2023 01:05
@elasticmachine

elasticmachine commented Sep 29, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

chemamartinez
chemamartinez approved these changes Sep 29, 2023
View reviewed changes

@chemamartinez chemamartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6
efd6 merged commit 0c8a0ae into elastic:main Sep 29, 2023
@elasticmachine

elasticmachine commented Sep 29, 2023

Copy link
Copy Markdown

Package cisco_asa - 2.24.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

1 similar comment
@elasticmachine

elasticmachine commented Sep 29, 2023

Copy link
Copy Markdown

Package cisco_asa - 2.24.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@efd6
efd6 deleted the 7757-cisco_asa branch February 5, 2025 22:04
@jsf-h jsf-h mentioned this pull request Feb 20, 2026
Closed
@Niceplace Niceplace mentioned this pull request May 5, 2026
Merged
5 tasks done
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
cisco_asa: expand set of accepted auth rejection reasons and retain r…
288246a 
…eason (elastic#8015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:cisco_asa Cisco ASA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pipeline fails to dissect Cisco ASA messages with ID 113005

3 participants

@efd6 @elasticmachine @chemamartinez