Repository navigation
[suricata] Defensive copy of parameter lists - #4731
Merged
Merged
Conversation
Copy list parameters before setting them into the context, rather than setting them directly -- this avoids leaking a 'static' mutable list (and the resulting concurrent modification exceptions).
joegallo
added
bug
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
P1llus
approved these changes
Nov 29, 2022
P1llus
left a comment
P1llus
left a comment
Member
There was a problem hiding this comment.
Just need to update the link on the changelog and then we merge.
|
Package suricata - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=suricata |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
* Defensive copy of param lists Copy list parameters before setting them into the context, rather than setting them directly -- this avoids leaking a 'static' mutable list (and the resulting concurrent modification exceptions). * Add an entry to the changelog * Bump the version number in the manifest * Update changelog link to the PR not the bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4723. Adds a defensive copy of the lists that we use from the params map, very much in the style of what was done previously in #3492.
Checklist
changelog.ymlfile.Related issues