Skip to content

o365: add record types beyond 66 - #3588

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:3380-o365
Jun 27, 2022
Merged

o365: add record types beyond 66#3588
efd6 merged 1 commit into
elastic:mainfrom
efd6:3380-o365

Conversation

@efd6

@efd6 efd6 commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This extends the mapped record types up to the currently listed set.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:o365 Microsoft Office 365 labels Jun 27, 2022
@efd6
efd6 requested a review from a team as a code owner June 27, 2022 05:14
@efd6 efd6 self-assigned this Jun 27, 2022
@elasticmachine

elasticmachine commented Jun 27, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-27T05:20:53.080+0000

  • Duration: 18 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.555
Classes 100.0% (1/1) 💚 3.555
Methods 100.0% (15/15) 💚 10.688
Lines 82.054% (727/886) 👎 -8.782
Conditionals 100.0% (0/0) 💚

r00tu53r
r00tu53r approved these changes Jun 27, 2022
View reviewed changes

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efd6
efd6 merged commit 205ab84 into elastic:main Jun 27, 2022
@andrewkroh andrewkroh mentioned this pull request Jun 27, 2022
Merged
@efd6 efd6 mentioned this pull request Jul 6, 2022
Merged
3 of 6 tasks
@efd6
efd6 deleted the 3380-o365 branch February 5, 2025 22:07
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
o365: add record types beyond 66 (elastic#3588)
916038f 
Types added from
https://docs.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-schema#enum-auditlogrecordtype---type-edmint32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@r00tu53r r00tu53r r00tu53r approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:o365 Microsoft Office 365

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @r00tu53r