Skip to content

[Crowdstrike] Add Falcon Event Streams support for APIActivityAuditEvent - #21269

Merged
sharad-elastic merged 5 commits into
elastic:mainfrom
sharad-elastic:crowdstrike-support_api_activity_audit_event
Oct 12, 2026
Merged

sharad-elastic merged 5 commits into
elastic:mainfrom
sharad-elastic:crowdstrike-support_api_activity_audit_event

Conversation

@sharad-elastic

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

Proposed commit message

crowdstrike: add falcon event streams support for APIActivityAuditEvent

Map CrowdStrike Falcon APIActivityAuditEvent fields to ECS and 
route them through a dedicated ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Collected live events from the CrowdStrike instance and verified the mappings in Elasticsearch.

Related issues

@sharad-elastic sharad-elastic self-assigned this Sep 15, 2026
@sharad-elastic
sharad-elastic requested review from a team as code owners September 15, 2026 12:48
@sharad-elastic sharad-elastic added Integration:crowdstrike CrowdStrike Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Sep 15, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

Comment thread packages/crowdstrike/changelog.yml Outdated
changes:
- description: Add support for APIActivityAuditEvent in the Falcon data stream.
type: enhancement
link: https://github.com/elastic/integrations/pull/1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: 🔵 Low confidence: high path: packages/crowdstrike/changelog.yml:6

Changelog link uses the placeholder pull number 1; replace it with this PR's URL.

Details

The new 4.10.0 changelog entry links to #1, which is a placeholder rather than the pull request introducing the change (21269). The changelog-link CI check will fail on the mismatch until it is updated.

Recommendation:

Point the link at this pull request.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/21269

🤖 AI-Generated Review | Vera Review Bot - v0.4.1 | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed. It's unclear to me why the CI is green when this is in place; the comment posted indicates a failure, but the gate is open.

cc @mrodm

@mrodm mrodm Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 We didn't want to block the CI because of this mismatch. We were not sure if there could be some reason to use another pull request link in the changelog entries.

That's why that for now this mismatch is reported as a comment: #21269 (comment)
but not blocking the CI even if the step fails in Buildkite (it is set as soft_fail in buildkite this step).

So we thought that the author must decide whether or not to update the changelog after the comment is posted.

@efd6 efd6 Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrodm. In this case, the existing text is clearly a placeholder and the change should be made before merging.

I would think that in general, if the author of a change thinks that the check should not be made, they have the option to set the label to skip the check. Is there a reason that is not enough?

@mrodm mrodm Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 That's true I think the label could help in those cases.

We wanted to start conservative and not break CI for unknown/edge cases. Since the changelog-link-check:skip label provides a clear escape hatch, we could change the implementation to fail that step.
Opened issue for this #21587.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@qcorporation qcorporation added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Sep 15, 2026
Comment thread packages/crowdstrike/changelog.yml Outdated
changes:
- description: Add support for APIActivityAuditEvent in the Falcon data stream.
type: enhancement
link: https://github.com/elastic/integrations/pull/1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed. It's unclear to me why the CI is green when this is in place; the comment posted indicates a failure, but the gate is open.

cc @mrodm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to review this properly we really need some documentation indication expected behaviour. Ideally this would be a table explaining what things exist and how they are to be mapped in the original issue and if possible, a link to documentation in the commit message (this may be paywalled, so if that's the case, it is not required).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the expected field → ECS mapping table on #20431.

CrowdStrike does not publish a stable public schema for Event Streams APIActivityAuditEvent; the table is derived from live events. I do not have a non-paywalled vendor doc URL to add to the commit message.

@sharad-elastic
sharad-elastic requested a review from efd6 September 28, 2026 08:41
@qcorporation qcorporation added the enhancement New feature or request label Sep 28, 2026
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@vera-review-bot

Copy link
Copy Markdown
Contributor

🟢 No issues across the latest commits 1fe49f9.

⚠️ 1 comment still unresolved from earlier commits — 1 low
  • 🔵 Changelog link uses the placeholder pull number 1 (link)

Review summary

Issues found across earlier commits 911a245 — 2 low
  • 🔵 Changelog link uses the placeholder pull number 1 (link) (Outdated)
  • 🔵 user_agent.original is populated but never parsed (link) (Outdated)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot - v0.4.2 | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @sharad-elastic

@sharad-elastic
sharad-elastic requested a review from efd6 September 30, 2026 09:46
@mergify

mergify Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@sharad-elastic
sharad-elastic merged commit 09d31fa into elastic:main Oct 12, 2026
16 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport branches

Important

Only active backport branches for packages changed by this PR are shown.

Tick the branches you want to backport to. A backport PR will be opened automatically for each branch you check.

Backport a change when it fixes behavior a branch already has; leave new behavior on main. See when and why to backport if you are unsure.

crowdstrike

  • backport-crowdstrike-1.52
  • backport-crowdstrike-1.46

Tip

If a branch above is no longer required, set archived: true in its entry in .backports.yml to stop it appearing here.
If the branch has a known end-of-life date, prefer maintained_until: "YYYY-MM-DD" — it will be excluded automatically once that date passes.

cc @sharad-elastic

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package crowdstrike - 4.10.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/4.10.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:crowdstrike CrowdStrike Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants