Repository navigation
[Crowdstrike] Add Falcon Event Streams support for APIActivityAuditEvent - #21269
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
| changes: | ||
| - description: Add support for APIActivityAuditEvent in the Falcon data stream. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/1 |
There was a problem hiding this comment.
Severity: 🔵 Low confidence: high path: packages/crowdstrike/changelog.yml:6
Changelog link uses the placeholder pull number 1; replace it with this PR's URL.
Details
The new 4.10.0 changelog entry links to #1, which is a placeholder rather than the pull request introducing the change (21269). The changelog-link CI check will fail on the mismatch until it is updated.
Recommendation:
Point the link at this pull request.
| link: https://github.com/elastic/integrations/pull/1 | |
| link: https://github.com/elastic/integrations/pull/21269 |
🤖 AI-Generated Review | Vera Review Bot - v0.4.1 | 📚 Knowledge base: integration-skills
⚠️ Automated review — verify suggestions before applying.
There was a problem hiding this comment.
This should be fixed. It's unclear to me why the CI is green when this is in place; the comment posted indicates a failure, but the gate is open.
cc @mrodm
There was a problem hiding this comment.
@efd6 We didn't want to block the CI because of this mismatch. We were not sure if there could be some reason to use another pull request link in the changelog entries.
That's why that for now this mismatch is reported as a comment: #21269 (comment)
but not blocking the CI even if the step fails in Buildkite (it is set as soft_fail in buildkite this step).
So we thought that the author must decide whether or not to update the changelog after the comment is posted.
There was a problem hiding this comment.
Thanks @mrodm. In this case, the existing text is clearly a placeholder and the change should be made before merging.
I would think that in general, if the author of a change thinks that the check should not be made, they have the option to set the label to skip the check. Is there a reason that is not enough?
There was a problem hiding this comment.
🚀 Benchmarks reportTo see the full report comment with |
| changes: | ||
| - description: Add support for APIActivityAuditEvent in the Falcon data stream. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/1 |
There was a problem hiding this comment.
This should be fixed. It's unclear to me why the CI is green when this is in place; the comment posted indicates a failure, but the gate is open.
cc @mrodm
There was a problem hiding this comment.
To be able to review this properly we really need some documentation indication expected behaviour. Ideally this would be a table explaining what things exist and how they are to be mapped in the original issue and if possible, a link to documentation in the commit message (this may be paywalled, so if that's the case, it is not required).
There was a problem hiding this comment.
Added the expected field → ECS mapping table on #20431.
CrowdStrike does not publish a stable public schema for Event Streams APIActivityAuditEvent; the table is derived from live events. I do not have a non-paywalled vendor doc URL to add to the commit message.
|
✅ All changelog entries have the correct PR link. |
|
🟢 No issues across the latest commits 1fe49f9.
|
💚 Build Succeeded
History
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Backport branchesImportant Only active backport branches for packages changed by this PR are shown. Tick the branches you want to backport to. A backport PR will be opened automatically for each branch you check. Backport a change when it fixes behavior a branch already has; leave new behavior on crowdstrike
Tip If a branch above is no longer required, set |
|
Package crowdstrike - 4.10.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/4.10.0/ |
Type of change
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
Related issues