[backport-aws-7.0] update elastic-package v0.126.1 - #21185
Open
teresaromero wants to merge 2 commits into
Open
teresaromero wants to merge 2 commits into
teresaromero wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Updates the backport branch to elastic-package v0.126.1, including the Google SDK fix.
Changes:
- Upgrades Elastic Package and related dependencies.
- Refreshes transitive dependency versions and checksums.
File summaries
| File | Description |
|---|---|
go.mod |
Updates direct and indirect dependencies. |
go.sum |
Refreshes dependency checksums. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mrodm
approved these changes
Sep 11, 2026
Backport of ecadef5 (PR elastic#20698) to backport-aws-7.0. The observability-ci account SCP now denies resource creation without the division/org/team/project tags, breaking the 11 SQS-based data stream system tests and redshift. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Nine moderate findings require correcting Terraform team tags to match the declared owners.
Review details
Suppressed comments (9)
packages/aws/data_stream/apigateway_logs/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:18assignsapigateway_logstoobs-infraobs-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/cloudfront_logs/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:22assignscloudfront_logstoobs-infraobs-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/elb_logs/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:32assignselb_logstoobs-infraobs-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/emr_logs/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:34assignsemr_logstoobs-infraobs-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/firewall_logs/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:36assignsfirewall_logstosecurity-service-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/redshift/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:46assignsredshifttoobs-infraobs-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/route53_resolver_logs/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:48assignsroute53_resolver_logstosecurity-service-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/vpcflow/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:60assignsvpcflowtosecurity-service-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
packages/aws/data_stream/waf/_dev/deploy/tf/main.tf:16
- The new
teamtag assigns this deployment toobs-ds-hosted-services, but.github/CODEOWNERS:62assignswaftosecurity-service-integrations. Because this is propagated as the AWS resource ownership metadata, use the declared owning team here.
team = "obs-ds-hosted-services"
- Files reviewed: 13/14 changed files
- Comments generated: 0 new
- Review effort level: Lite
Contributor
|
✅ Package owners are in sync with |
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
firewall_logs |
4651.16 | 3184.71 | -1466.45 (-31.53%) | 💔 |
inspector |
1592.36 | 1176.47 | -415.89 (-26.12%) | 💔 |
apigateway_logs |
20000 | 14925.37 | -5074.63 (-25.37%) | 💔 |
cloudfront_logs |
3164.56 | 2262.44 | -902.12 (-28.51%) | 💔 |
cloudtrail |
2421.31 | 1953.13 | -468.18 (-19.34%) | 💔 |
config |
4081.63 | 3012.05 | -1069.58 (-26.2%) | 💔 |
ec2_logs |
58823.53 | 47619.05 | -11204.48 (-19.05%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
|
MichaelKatsoulis
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating backport branch with elastic-package v0.126.1 which fixes the google sdk error https://buildkite.com/elastic/integrations/builds/49467#01a08d0f-56b5-4ef9-8f13-9d7c4fd6c989/L2762