Skip to content

[qualys_gav] Bump latest-asset dest index to apply lookup index mode on upgrade - #20191

Merged
efd6 merged 8 commits into
elastic:mainfrom
clement-fouque:qualys_gav-bump-dest-asset-lookup
Jul 21, 2026
Merged

efd6 merged 8 commits into
elastic:mainfrom
clement-fouque:qualys_gav-bump-dest-asset-lookup

Conversation

@clement-fouque

@clement-fouque clement-fouque commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Proposed commit message

[qualys_gav] Bump latest-asset dest index so lookup mode applies on upgrade

#20080 configured lookup index mode but did not bump the destination
index suffix, so existing upgrades kept the old index without the mode.
Bump dest_asset-2 → dest_asset-3 (and fleet_transform_version) so a new
destination index is created with lookup mode.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

…ansform_version to 0.4.0. Adjust destination index to logs-qualys_gav_latest.dest_asset-3 to reflect changes in index mapping. Add comments regarding index versioning and transform configuration updates.
@github-actions

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Integration:qualys_gav Qualys Global AssetView label Jul 17, 2026
@clement-fouque
clement-fouque marked this pull request as ready for review July 17, 2026 14:43
@clement-fouque
clement-fouque requested review from a team as code owners July 17, 2026 14:43
@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 17, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@clement-fouque

Copy link
Copy Markdown
Contributor Author

@elastic/security-service-integrations can you please review this PR (and merge if ok since I don't have the right)? Thank you.

Comment thread packages/qualys_gav/changelog.yml Resolved
Comment thread packages/qualys_gav/changelog.yml Resolved
@vera-review-bot

Copy link
Copy Markdown
Contributor

Review summary

Issues found across the latest commits a068945 — 1 medium
  • 🟡 Changelog links a different PR number (link) (Unresolved)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@clement-fouque

Copy link
Copy Markdown
Contributor Author

@elastic/security-service-integrations it's ready for review. Thank you.

@kcreddy

kcreddy commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/test

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Changelog link mismatch — expected https://github.com/elastic/integrations/pull/20191 in the following file(s):

  • packages/qualys_gav/changelog.yml

Tip

If expected, add the changelog-link-check:skip label to skip this check. Or, if an issue link was intended, use .../issues/<n> instead.

View Buildkite build
@clement-fouque

@clement-fouque

Copy link
Copy Markdown
Contributor Author

@kcreddy can you add again the label changelog-link-check:skip as it's preventing the build to succeed? Thanks.

@kcreddy

kcreddy commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

@kcreddy can you add again the label changelog-link-check:skip as it's preventing the build to succeed? Thanks.

I just noticed the CI failure reason now. Apologies for the confusion. Added it back.

@kcreddy

kcreddy commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/test

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. LGTM.
Please wait for Dan's approval.

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@mergify

mergify Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@clement-fouque

Copy link
Copy Markdown
Contributor Author

@efd6 if you approve it, can you merge it as I don't have the right anymore? Thank you.

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit 595ae94 into elastic:main Jul 21, 2026
12 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package qualys_gav - 0.9.1 containing this change is available at https://epr.elastic.co/package/qualys_gav/0.9.1/

@clement-fouque
clement-fouque deleted the qualys_gav-bump-dest-asset-lookup branch August 31, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-link-check:skip documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:qualys_gav Qualys Global AssetView Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants