Repository navigation
[CI] Improve changelog link check TIP message to mention issue links - #19379
Merged
Merged
Conversation
mrodm
force-pushed
the
update_changelog_link_message
branch
from
June 4, 2026 10:57
111cbd7 to
31f77a8
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mrodm
force-pushed
the
update_changelog_link_message
branch
from
June 4, 2026 11:02
31f77a8 to
d5380f9
Compare
mrodm
commented
Jun 4, 2026
| message+="- \`${f}\`"$'\n' | ||
| done | ||
| message+=$'\n'"> [!TIP]"$'\n'"> Add the \`${CHANGELOG_SKIP_LABEL}\` label to skip this check." | ||
| message+=$'\n'"> [!TIP]"$'\n'"> If expected, add the \`${CHANGELOG_SKIP_LABEL}\` label to skip this check. Or, if an issue link was intended, use \`.../issues/<n>\` instead." |
Collaborator
Author
There was a problem hiding this comment.
It would be rendered as:
Tip
If expected, add the changelog-link-check:skip label to skip this check. Or, if an issue link was intended, use.../issues/<n> instead.
💚 Build Succeeded
History
cc @mrodm |
mrodm
marked this pull request as ready for review
June 4, 2026 11:11
jsoriano
approved these changes
Jun 4, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT:
Update the error TIP callout in
.buildkite/scripts/check_changelog_entries.shto mention that an issue link (.../issues/<n>) can be used in thelink:field as an alternative to the current PR link — the check already accepts issue links without validation.WHY:
The original TIP only mentioned the
changelog-link-check:skiplabel, leaving developers unaware that they can simply use an issue link if that is their intent. This small addition makes the error message more actionable and self-contained.Author's Checklist
Related issues