Skip to content

[axonius] Axonius all datastreams sync - #19335

Merged
kcreddy merged 6 commits into
elastic:feature/axonius-0.1.0from
muskan-agarwal26:axonius-all-datastreams-sync
Jun 4, 2026
Merged

kcreddy merged 6 commits into
elastic:feature/axonius-0.1.0from
muskan-agarwal26:axonius-all-datastreams-sync

Conversation

@muskan-agarwal26

@muskan-agarwal26 muskan-agarwal26 commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

Proposed commit message

  1. Update cel code and manifest to use asset_type_list var
  2. Remove event.data.* and map fields on root level.
  3. Remove drop event from pipeline
  4. Update transform frequency to 90d for assets
  5. ILM retention to 30d for assets
  6. Add visual level filter in dashboard
  7. Add remove inside on_failure in convert processor
  8. Change tenant_number field type to long and description/summary field type to text
  9. Add fingerprint description and code comments in transform, as added in network datastream
  10. Add note in overview of dashboard for assets
  11. Update the if condition in all pipeline processors to be in the format: ctx.axonius?.asset_type == pattern

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

To test the Axonius package:

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/axonius directory.
  • Run the following command to run tests.

Related issues

2. remove event.data.*  and map fields on root level.
3. remove drop event from pipeline
4. update transform frequency to 90d for assets
5. ILM retention to 30d for assets
6. Add visual level filter in dashboard
7. Add remove inside on_failure in convert processor
8. Change tenant_number field type to long and description/summary field type to text
9. Add fingerprint description and code comments in transform, as added in network datastream
10. Add note in overview of dashboard for assets
11. Update the if condition in all pipeline processors to be in the format: ctx.axonius?.asset_type ==  pattern.
@muskan-agarwal26
muskan-agarwal26 requested a review from a team as a code owner June 2, 2026 09:52
@muskan-agarwal26 muskan-agarwal26 changed the title [axonius] ll datastreams sync [axonius] All datastreams sync Jun 2, 2026
@muskan-agarwal26
muskan-agarwal26 changed the base branch from main to feature/axonius-0.1.0 June 2, 2026 09:53
@muskan-agarwal26
muskan-agarwal26 requested a review from a team as a code owner June 2, 2026 09:53
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Elastic Docs Style Checker (Vale)

Summary: 1 suggestion found

💡 Suggestions (1): Optional style improvements. Apply when helpful.
File Line Rule Message
packages/axonius/changelog.yml 1 Elastic.Versions Use 'later versions' instead of 'newer versions' when referring to versions.

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@muskan-agarwal26 muskan-agarwal26 changed the title [axonius] All datastreams sync [axonius] Axonius all datastreams sync Jun 2, 2026
@kcreddy

kcreddy commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

/test

@kcreddy kcreddy added the Crest Contributions from Crest developement team. label Jun 2, 2026
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Comment thread packages/axonius/changelog.yml Resolved
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jun 2, 2026

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the change of the summary field type from keyword to text, is this a breaking change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has two panels outside the 48-column grid.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dashboard has 28 panels. Can this be reduced to within the guidelines?

It has two panels outside the 48 column grid.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any link to the such constraint guides, could you please share? @efd6

@efd6 efd6 Jun 4, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidelines are at https://www.elastic.co/docs/extend/integrations/dashboard-guidelines. This doesn't mention a number, but a survey of our dashboards puts 20 at the 95th percentile (the maximum count for all of ours is 31). The 90th is 16. If you really need 28, I guess it's OK, but it would be good to reduce it by splitting; the cognitive load of an over-populated dashboard impacts on usability.

The 48 column width is from here.

@muskan-agarwal26
muskan-agarwal26 requested review from efd6 and kcreddy June 4, 2026 07:51
{
"id": "axonius-50841034-1314-4e26-8be3-47d38241c359",
"name": "8b80beb8-b690-4c97-b666-109970047966:link_50841034-1314-4e26-8be3-47d38241c359_dashboard",
"type": "dashboard"
}
],
"type": "dashboard",
"typeMigrationVersion": "10.2.0",
"updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know what is the context here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These get updated each time by the dashboard is updated. They contribute to churn.

"typeMigrationVersion": "10.2.0"
}
"typeMigrationVersion": "10.2.0",
"updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0"

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please wait for @efd6 approval

@muskan-agarwal26
muskan-agarwal26 requested a review from efd6 June 4, 2026 08:51
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@kcreddy
kcreddy merged commit e757343 into elastic:feature/axonius-0.1.0 Jun 4, 2026
4 checks passed
@kcreddy kcreddy mentioned this pull request Jun 4, 2026
1 of 5 tasks
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package axonius - 0.1.0 containing this change is available at https://epr.elastic.co/package/axonius/0.1.0/

@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:axonius Axonius labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Crest Contributions from Crest developement team. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:axonius Axonius

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants