Repository navigation
Conversation
2. remove event.data.* and map fields on root level. 3. remove drop event from pipeline 4. update transform frequency to 90d for assets 5. ILM retention to 30d for assets 6. Add visual level filter in dashboard 7. Add remove inside on_failure in convert processor 8. Change tenant_number field type to long and description/summary field type to text 9. Add fingerprint description and code comments in transform, as added in network datastream 10. Add note in overview of dashboard for assets 11. Update the if condition in all pipeline processors to be in the format: ctx.axonius?.asset_type == pattern.
Elastic Docs Style Checker (Vale)Summary: 1 suggestion found 💡 Suggestions (1): Optional style improvements. Apply when helpful.
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
efd6
left a comment
There was a problem hiding this comment.
With the change of the summary field type from keyword to text, is this a breaking change?
There was a problem hiding this comment.
This has two panels outside the 48-column grid.
There was a problem hiding this comment.
This dashboard has 28 panels. Can this be reduced to within the guidelines?
It has two panels outside the 48 column grid.
There was a problem hiding this comment.
Is there any link to the such constraint guides, could you please share? @efd6
There was a problem hiding this comment.
The guidelines are at https://www.elastic.co/docs/extend/integrations/dashboard-guidelines. This doesn't mention a number, but a survey of our dashboards puts 20 at the 95th percentile (the maximum count for all of ours is 31). The 90th is 16. If you really need 28, I guess it's OK, but it would be good to reduce it by splitting; the cognitive load of an over-populated dashboard impacts on usability.
The 48 column width is from here.
| { | ||
| "id": "axonius-50841034-1314-4e26-8be3-47d38241c359", | ||
| "name": "8b80beb8-b690-4c97-b666-109970047966:link_50841034-1314-4e26-8be3-47d38241c359_dashboard", | ||
| "type": "dashboard" | ||
| } | ||
| ], | ||
| "type": "dashboard", | ||
| "typeMigrationVersion": "10.2.0", | ||
| "updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0" |
There was a problem hiding this comment.
| "updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0" |
There was a problem hiding this comment.
May I know what is the context here?
There was a problem hiding this comment.
These get updated each time by the dashboard is updated. They contribute to churn.
| "typeMigrationVersion": "10.2.0" | ||
| } | ||
| "typeMigrationVersion": "10.2.0", | ||
| "updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0" |
There was a problem hiding this comment.
| "updated_by": "u_mGBROF_q5bmFCATbLXAcCwKa0k8JvONAwSruelyKA5E_0" |
💚 Build Succeeded
History
|
|
Package axonius - 0.1.0 containing this change is available at https://epr.elastic.co/package/axonius/0.1.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
To test the Axonius package:
Related issues