Skip to content

aws/vpcflow: surface unsupported flow log formats as pipeline errors - #18899

Merged
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:aws-vpcflow-custom-patterns
May 19, 2026
Merged

aws/vpcflow: surface unsupported flow log formats as pipeline errors#18899
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:aws-vpcflow-custom-patterns

Conversation

@kcreddy

@kcreddy kcreddy commented May 8, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

aws/vpcflow: surface unsupported flow log formats as pipeline errors

Records with a field count that does not match any known VPC Flow Log
layout were silently indexed without parsed fields. Add a fail guard
after the dissect branches so these records trigger the pipeline-level
on_failure handler, setting event.kind to pipeline_error with a
descriptive message. Custom ingest pipelines continue to run and can
override the error for formats they handle.

Closes elastic/integrations#18521

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Records with a field count that does not match any known VPC Flow Log
layout were silently indexed without parsed fields. Add a fail guard
after the dissect branches so these records trigger the pipeline-level
on_failure handler, setting event.kind to pipeline_error with a
descriptive message. Custom ingest pipelines continue to run and can
override the error for formats they handle.

Closes elastic#18521
@kcreddy kcreddy self-assigned this May 8, 2026
@kcreddy kcreddy added Integration:aws AWS enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 8, 2026
Comment on lines +72 to +77
- fail:
if: ctx?._temp_?.message_token_count != null && ctx?.aws?.vpcflow?.srcaddr == null
message: >-
Unsupported VPC Flow Log format: record has {{{_temp_.message_token_count}}} fields,
which does not match any integration supported VPC flow log format.
Use a custom ingest pipeline to parse this format.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fail used here instead of terminate because terminate hides the problem, fail surfaces it.

@kcreddy
kcreddy marked this pull request as ready for review May 8, 2026 13:47
@kcreddy
kcreddy requested review from a team as code owners May 8, 2026 13:47
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy

kcreddy commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

The CI is failing on an unrelated aws.config test failure.

@kcreddy

kcreddy commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

/test

@kcreddy
kcreddy marked this pull request as draft May 12, 2026 06:22
@kcreddy

kcreddy commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

The CI error is due to the expired certificate on aws.config. #18881 should fix the problem. Until that is merged, moving this PR to draft.

@kcreddy

kcreddy commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

/test

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy
kcreddy marked this pull request as ready for review May 18, 2026 13:29
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kcreddy

@kcreddy
kcreddy merged commit ddd7570 into elastic:main May 19, 2026
8 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package aws - 6.16.0 containing this change is available at https://epr.elastic.co/package/aws/6.16.0/

herrBez pushed a commit to herrBez/integrations that referenced this pull request Jun 1, 2026
…lastic#18899)

Records with a field count that does not match any known VPC Flow Log
layout were silently indexed without parsed fields. Add a fail guard
after the dissect branches so these records trigger the pipeline-level
on_failure handler, setting event.kind to pipeline_error with a
descriptive message. Custom ingest pipelines continue to run and can
override the error for formats they handle.

Closes elastic#18521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:aws AWS Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ingest-pipeline-safety] AWS VPC Flow pipeline silently accepts unsupported custom-format records

3 participants