Repository navigation
Jamf Pro: add support for ECS entity fields - #18503
Conversation
Vale Linting ResultsSummary: 6 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/jamf_pro/docs/README.md | 204 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/jamf_pro/docs/README.md | 205 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/jamf_pro/docs/README.md | 206 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/jamf_pro/docs/README.md | 511 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/jamf_pro/docs/README.md | 512 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/jamf_pro/docs/README.md | 513 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
left a comment
There was a problem hiding this comment.
Add the provenance of the test inputs to the commit message.
| if (ctx.host == null) { | ||
| ctx.host = [:]; | ||
| } |
There was a problem hiding this comment.
| if (ctx.host == null) { | |
| ctx.host = [:]; | |
| } | |
| ctx.host = ctx.host ?: [:]; |
(similar below)
| source: |- | ||
| List admins = new ArrayList(); | ||
| for (def acct : ctx.jamf_pro.inventory.local_user_accounts) { | ||
| if (acct.admin == true) { |
There was a problem hiding this comment.
Prefer to invert the condition and continue in that case. This moves the code left.
💚 Build Succeeded
History
|
|
@chemamartinez is adding *.relationships should be part of this PR? is it something that could be added or is there another PR that should address it? |
|
@alexreal1314 for the administers field, it happens the same as for the other integrations, we decided to revert the change after it switched the direction (see 3616e5d), as from the source we only can get the administrator for each entity. It happens the same with the That data is still available in dedicated custom fields in events, so these fields can be correlated and populated in later steps with transforms or ESQL. |
|
Package jamf_pro - 1.2.0 containing this change is available at https://epr.elastic.co/package/jamf_pro/1.2.0/ |
Proposed commit message
Checklist
changelog.ymlfile.Related issues