Skip to content

cloudflare_logpush: expand set of supported fields and add data streams - #12782

Merged
efd6 merged 11 commits into
elastic:mainfrom
efd6:9809-cloudflare_logpush
Apr 2, 2025
Merged

efd6 merged 11 commits into
elastic:mainfrom
efd6:9809-cloudflare_logpush

Conversation

@efd6

@efd6 efd6 commented Feb 13, 2025 •

Copy link
Copy Markdown
Contributor

Proposed commit message

See title.

Warning

No test cases are available for the new fields and tests for the new data streams are constructed from documentation without any ground truth.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 13, 2025
@efd6 efd6 self-assigned this Feb 13, 2025
@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch from e3ca826 to 7b5c0ea Compare February 13, 2025 22:31
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Feb 13, 2025 •

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch 3 times, most recently from b4e8594 to 3700282 Compare March 5, 2025 23:36
@efd6 efd6 changed the title cloudflare_logpush: expand set of supported fields cloudflare_logpush: expand set of supported fields and add data streams Mar 5, 2025
@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch from 3700282 to 40b0641 Compare March 6, 2025 00:26
@efd6
efd6 marked this pull request as ready for review March 6, 2025 01:25
@efd6
efd6 requested a review from a team as a code owner March 6, 2025 01:25
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch from 40b0641 to a92b51b Compare March 6, 2025 10:06

@chemamartinez chemamartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to add some fields for the gateway_http data stream, the ones that are not linked in the table of the original issue.

Notice that the link to the documentation for the gateway_http data stream is pointing to the gateway_network dataset so that should be why you couldn't find them.

@andrewkroh andrewkroh added the Integration:entityanalytics_ad Active Directory Entity Analytics label Mar 13, 2025
@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch from 7a1c24e to 546acaf Compare March 13, 2025 22:31
@efd6

efd6 commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

@chemamartinez I marked the missing (now corrected) fields in the table in the issue with a * so that it's clear which were added. The link is also fixed — thanks for noticing that.

@andrewkroh andrewkroh removed the Integration:entityanalytics_ad Active Directory Entity Analytics label Mar 13, 2025
@efd6
efd6 requested a review from chemamartinez March 13, 2025 23:10

@chemamartinez chemamartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left. Apart from that, it looks good!

@efd6 efd6 mentioned this pull request Mar 11, 2025
61 of 66 tasks
@efd6
efd6 requested review from chemamartinez and kcreddy March 16, 2025 02:38
@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch from 7928300 to cce278d Compare March 26, 2025 01:12
@andrewkroh andrewkroh added the Integration:entityanalytics_ad Active Directory Entity Analytics label Mar 26, 2025
@efd6
efd6 force-pushed the 9809-cloudflare_logpush branch from cce278d to 35543da Compare March 30, 2025 21:14
@andrewkroh andrewkroh removed the Integration:entityanalytics_ad Active Directory Entity Analytics label Mar 31, 2025
@elastic-sonarqube

Copy link
Copy Markdown

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @efd6

@efd6
efd6 merged commit 5976650 into elastic:main Apr 2, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cloudflare_logpush - 1.36.0 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.36.0/

flexitrev pushed a commit that referenced this pull request Apr 3, 2025
…ms (#12782)

New data streams:
* page_shield_events
* dlp_forensic_copies
* email_security_alerts

Tests for new data streams were hand crafted from the API documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cloudflare Logpush] Add support for new fields and Page Shield data stream

5 participants