[8.19] (backport #13623) [edot] add suppress_conflict_errors to exporter - #13665
mergify[bot] wants to merge 2 commits into
Conversation
* chore: add suppress_conflict_errors * fix unit tests * readme and notice * remove from agent * lint * beats (cherry picked from commit 0409211) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum # internal/edot/go.mod # internal/edot/go.sum # internal/pkg/otel/README.md # internal/pkg/otel/translate/output_elasticsearch.go # internal/pkg/otel/translate/output_elasticsearch_test.go
|
Cherry-pick of 0409211 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
22d8490 to
4bf5e2a
Compare
TL;DRThe Remediation
Investigation detailsRoot CauseThe GitHub Actions job Evidence
Validation
Follow-up
What is this? | From workflow: PR Actions Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
| "logs_dynamic_pipeline": map[string]any{ | ||
| "enabled": true, | ||
| }, | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
🔴 Critical translate/output_elasticsearch.go:158
Unresolved Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> 040921166) are present at lines 158-164, which causes a compilation error. The merge conflict needs to be resolved by choosing between the HEAD version (empty) or the incoming version that adds logs_dynamic_id, include_source_on_error, retry, and suppress_conflict_errors fields.
Also found in 1 other location(s)
internal/pkg/otel/translate/output_elasticsearch_test.go:161
Unresolved git merge conflict markers (
<<<<<<< HEAD,=======,>>>>>>> 040921166) left in the test file at lines 161-230. These are not valid Go syntax and will cause a compilation error.
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file internal/pkg/otel/translate/output_elasticsearch.go around line 158:
Unresolved Git merge conflict markers (`<<<<<<< HEAD`, `=======`, `>>>>>>> 040921166`) are present at lines 158-164, which causes a compilation error. The merge conflict needs to be resolved by choosing between the HEAD version (empty) or the incoming version that adds `logs_dynamic_id`, `include_source_on_error`, `retry`, and `suppress_conflict_errors` fields.
Evidence trail:
internal/pkg/otel/translate/output_elasticsearch.go lines 150-175 at REVIEWED_COMMIT. The merge conflict markers `<<<<<<< HEAD`, `=======`, and `>>>>>>> 040921166` are clearly visible at lines 158-164.
Also found in 1 other location(s):
- internal/pkg/otel/translate/output_elasticsearch_test.go:161 -- Unresolved git merge conflict markers (`<<<<<<< HEAD`, `=======`, `>>>>>>> 040921166`) left in the test file at lines 161-230. These are not valid Go syntax and will cause a compilation error.
|
Hello, this merge failed - is it expected? |
|
Beats receivers is not enabled by default anywhere in 8.19. The option on the exporter itself will become available through the separate updates of the OpenTelemetry component dependencies for those using EDOT collector directly in 8.19. |
What does this PR do?
This PR pulls in
suppress_conflict_errorsfrom open-telemetry/opentelemetry-collector-contrib#47309 to avoid logging errors for 409 status code. This PR also pins the exporter version to open-telemetry/opentelemetry-collector-contrib@ffa805c to pull in changes. Once the versions are bumped, we can remove the replace directive.Why is it important?
Beats elasticsearch output ignores 409 status code and doesn't log the error. This PR is needed to achieve parity between hybrid mode and standalone mode.
Checklist
./changelog/fragmentsusing the changelog toolRelated issues
This is an automatic backport of pull request #13623 done by [Mergify](https://mergify.com).