Skip to content

[8.19] (backport #13623) [edot] add suppress_conflict_errors to exporter - #13665

Closed
mergify[bot] wants to merge 2 commits into
8.19from
mergify/bp/8.19/pr-13623
Closed

mergify[bot] wants to merge 2 commits into
8.19from
mergify/bp/8.19/pr-13623

Conversation

@mergify

@mergify mergify Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR pulls in suppress_conflict_errors from open-telemetry/opentelemetry-collector-contrib#47309 to avoid logging errors for 409 status code. This PR also pins the exporter version to open-telemetry/opentelemetry-collector-contrib@ffa805c to pull in changes. Once the versions are bumped, we can remove the replace directive.

Why is it important?

Beats elasticsearch output ignores 409 status code and doesn't log the error. This PR is needed to achieve parity between hybrid mode and standalone mode.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues


This is an automatic backport of pull request #13623 done by [Mergify](https://mergify.com).

* chore: add suppress_conflict_errors

* fix unit tests

* readme and notice

* remove from agent

* lint

* beats

(cherry picked from commit 0409211)

# Conflicts:
#	NOTICE-fips.txt
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/edot/go.mod
#	internal/edot/go.sum
#	internal/pkg/otel/README.md
#	internal/pkg/otel/translate/output_elasticsearch.go
#	internal/pkg/otel/translate/output_elasticsearch_test.go
@mergify
mergify Bot requested a review from a team as a code owner April 16, 2026 14:19
@mergify mergify Bot added the backport label Apr 16, 2026
@mergify
mergify Bot removed the request for review from a team April 16, 2026 14:19
@mergify mergify Bot added the conflicts There is a conflict in the backported pull request label Apr 16, 2026
@mergify
mergify Bot requested review from blakerouse and swiatekm April 16, 2026 14:19
@mergify

mergify Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 0409211 has failed:

On branch mergify/bp/8.19/pr-13623
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 040921166.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .golangci.yml
	new file:   changelog/fragments/1776160579-esexporter-supress-409.yaml
	modified:   internal/pkg/otel/translate/otelconfig_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE-fips.txt
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum
	both modified:   internal/edot/go.mod
	both modified:   internal/edot/go.sum
	both modified:   internal/pkg/otel/README.md
	both modified:   internal/pkg/otel/translate/output_elasticsearch.go
	both modified:   internal/pkg/otel/translate/output_elasticsearch_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions Bot added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Apr 16, 2026
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Comment thread internal/pkg/otel/README.md Outdated
@VihasMakwana
VihasMakwana force-pushed the mergify/bp/8.19/pr-13623 branch from 22d8490 to 4bf5e2a Compare April 16, 2026 20:10
@github-actions

Copy link
Copy Markdown
Contributor

TL;DR

The pre-commit workflow run failed in the check-merge-conflict hook because unresolved merge conflict markers were committed in this backport branch. Resolve the conflict markers in the listed files and push an updated commit.

Remediation

  • Open and resolve the conflict markers (<<<<<<<, =======, >>>>>>>) in:
    • internal/pkg/otel/translate/output_elasticsearch.go
    • internal/pkg/otel/README.md
    • internal/pkg/otel/translate/output_elasticsearch_test.go
  • Re-run local checks before pushing (at minimum pre-commit run -a or equivalent repo pre-commit target) to confirm no conflict markers remain.
Investigation details

Root Cause

The GitHub Actions job pre-commit failed at the step Run elastic/oblt-actions/pre-commit@v1 because the check-merge-conflict hook detected unresolved merge markers in tracked files.

Evidence

  • Workflow: https://github.com/elastic/elastic-agent/actions/runs/24531453268
  • Job/step: pre-commit → Run elastic/oblt-actions/pre-commit@v1 → hook check-merge-conflict
  • Key log excerpt:
    • internal/pkg/otel/translate/output_elasticsearch.go:158: Merge conflict string '<<<<<<<' found
    • internal/pkg/otel/README.md:50: Merge conflict string '<<<<<<<' found
    • internal/pkg/otel/translate/output_elasticsearch_test.go:161: Merge conflict string '<<<<<<<' found
    • ##[error]Process completed with exit code 1.

Validation

  • Not run locally (this workflow is read-only; diagnosis based on workflow job logs).

Follow-up

  • After resolving markers, re-run the PR checks to verify the pre-commit job passes.

What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

"logs_dynamic_pipeline": map[string]any{
"enabled": true,
},
<<<<<<< HEAD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical translate/output_elasticsearch.go:158

Unresolved Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>> 040921166) are present at lines 158-164, which causes a compilation error. The merge conflict needs to be resolved by choosing between the HEAD version (empty) or the incoming version that adds logs_dynamic_id, include_source_on_error, retry, and suppress_conflict_errors fields.

Also found in 1 other location(s)

internal/pkg/otel/translate/output_elasticsearch_test.go:161

Unresolved git merge conflict markers (&lt;&lt;&lt;&lt;&lt;&lt;&lt; HEAD, =======, &gt;&gt;&gt;&gt;&gt;&gt;&gt; 040921166) left in the test file at lines 161-230. These are not valid Go syntax and will cause a compilation error.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file internal/pkg/otel/translate/output_elasticsearch.go around line 158:

Unresolved Git merge conflict markers (`<<<<<<< HEAD`, `=======`, `>>>>>>> 040921166`) are present at lines 158-164, which causes a compilation error. The merge conflict needs to be resolved by choosing between the HEAD version (empty) or the incoming version that adds `logs_dynamic_id`, `include_source_on_error`, `retry`, and `suppress_conflict_errors` fields.

Evidence trail:
internal/pkg/otel/translate/output_elasticsearch.go lines 150-175 at REVIEWED_COMMIT. The merge conflict markers `<<<<<<< HEAD`, `=======`, and `>>>>>>> 040921166` are clearly visible at lines 158-164.

Also found in 1 other location(s):
- internal/pkg/otel/translate/output_elasticsearch_test.go:161 -- Unresolved git merge conflict markers (`<<<<<<< HEAD`, `=======`, `>>>>>>> 040921166`) left in the test file at lines 161-230. These are not valid Go syntax and will cause a compilation error.

@elasticmachine

elasticmachine commented Apr 16, 2026 •

Copy link
Copy Markdown
Contributor

@mergify
mergify Bot deleted the mergify/bp/8.19/pr-13623 branch April 17, 2026 10:18
@lucabelluccini

Copy link
Copy Markdown
Contributor

Hello, this merge failed - is it expected?

@cmacknz

cmacknz commented Apr 23, 2026

Copy link
Copy Markdown
Member

Beats receivers is not enabled by default anywhere in 8.19. The option on the exporter itself will become available through the separate updates of the OpenTelemetry component dependencies for those using EDOT collector directly in 8.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants