Skip to content

[8.19] (backport #13436) Replace deprecated LoggingWithTypedOutputs #13542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orestisfl merged 3 commits into from
Apr 28, 2026
Merged

[8.19] (backport #13436) Replace deprecated LoggingWithTypedOutputs #13542

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
555516d
Replace deprecated LoggingWithTypedOutputs with LoggingWithTypedOutpu…
orestisfl Apr 8, 2026
76ebfec
Merge branch '8.19' into mergify/bp/8.19/pr-13436
orestisfl Apr 17, 2026
37a5d51
Merge branch '8.19' into mergify/bp/8.19/pr-13436
orestisfl Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/core/logger/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,12 @@
return nil, fmt.Errorf("could not convert event log config: %w", err)
}

if err := configure.LoggingWithTypedOutputs("", commonCfg, eventLoggercommonCfg, "log.type", "event", outputs...); err != nil {
logger, err := configure.LoggingWithTypedOutputsLocal("", commonCfg, eventLoggercommonCfg, "log.type", "event", outputs...)
if err != nil {
return nil, fmt.Errorf("error initializing logging: %w", err)
}

return logp.NewLogger(name), nil
return logger.Named(name), nil
}

func ToCommonConfig(cfg *Config) (*config.C, error) {
Expand Down Expand Up @@ -219,7 +220,7 @@
rotator, err := file.NewFileRotator(filename,
file.MaxSizeBytes(defaultCfg.Files.MaxSize),
file.MaxBackups(defaultCfg.Files.MaxBackups),
file.Permissions(os.FileMode(permissions)),

Check failure on line 223 in pkg/core/logger/logger.go

View workflow job for this annotation

GitHub Actions / lint (ubuntu-latest) 

G115: integer overflow conversion int -> uint32 (gosec)
file.Interval(defaultCfg.Files.Interval),
file.RotateOnStartup(defaultCfg.Files.RotateOnStartup),
file.RedirectStderr(defaultCfg.Files.RedirectStderr),
Expand Down
Loading