Skip to content

Add workflow to manually test the updatecli bumps - #12227

Closed
fr4nc1sc0-r4m0n wants to merge 6 commits into
mainfrom
feature/test-updatecli-vm-images
Closed

fr4nc1sc0-r4m0n wants to merge 6 commits into
mainfrom
feature/test-updatecli-vm-images

Conversation

@fr4nc1sc0-r4m0n

Copy link
Copy Markdown
Contributor

What does this PR do?

Add workflow to manually test the updatecli bumps on the vm images

Why is it important?

To have a mechanism to test the future updatecli bumps because the current workflows always run over the active branches.

Helps to test these kind of PRs:

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n self-assigned this Jan 13, 2026
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n requested a review from a team as a code owner January 13, 2026 13:25
@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n added the chore Tasks that just need to be done, they are neither bug, nor enhancements label Jan 13, 2026
@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n requested a review from a team as a code owner January 13, 2026 13:25
@mergify

mergify Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @fr4nc1sc0-r4m0n? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Comment on lines +18 to +19
contents: write
pull-requests: write

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no push, what's the reason we use write here?

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n Jan 13, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Even contents: write, right?
See 33a5acf

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 13, 2026
@elasticmachine

Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n enabled auto-merge (squash) January 14, 2026 08:59
@ebeahan

ebeahan commented Apr 16, 2026

Copy link
Copy Markdown
Member

@fr4nc1sc0-r4m0n this PR has been open for a bit and still not merged. Are these changes still needed?

@fr4nc1sc0-r4m0n

Copy link
Copy Markdown
Contributor Author

Thanks @ebeahan for bumping this. I completely forgot this PR. I think that could make sense to merge it since this could help us to test the updatecli bumps in other branches a part from the active ones. WDYT @v1v ?

@fr4nc1sc0-r4m0n

Copy link
Copy Markdown
Contributor Author

After talking with the team, I'm closing this since we can test it locally and no hard requirement for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants