Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
miguelgrinberg
approved these changes
Oct 28, 2025
edsavage
approved these changes
Oct 28, 2025
Contributor
edsavage
left a comment
There was a problem hiding this comment.
LGTM
Note that this PyTorch version includes a fix for a CVE.
which resulted in Huggingface disabling the torch.load method for certain models in in version 4.51.
For this reason the Huggingface version was pinned to 4.50.3 in Eland (to ensure model upload still worked.) It should now be fine to upgrade Huggingface to a version later than 4.50.3
Member
Author
|
Somehow I pushed the PyTorch upgrade in #810, so this is only about the transformers ugprade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following elastic/ml-cpp#2863, which was only applied to 9.x, not 8.x