Skip to content

Upgrade all AWs to v0.85.4; add Team:Experience/Ingest labels to triage - #275

Merged
theletterf merged 4 commits into
mainfrom
fix/aw-actions-write-and-team-labels
Aug 10, 2026
Merged

Upgrade all AWs to v0.85.4; add Team:Experience/Ingest labels to triage#275
theletterf merged 4 commits into
mainfrom
fix/aw-actions-write-and-team-labels

Conversation

@theletterf

@theletterf theletterf commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Upgrades all 14 agentic workflows from gh-aw v0.83.4 → v0.85.4 via gh aw upgrade.
  • Adds Team:Experience and Team:Ingest to the add-labels allowed list in the two triage workflows (they were in the docs-content team mapping but missing from the safe-outputs allowlist).

Changelog highlights (v0.83.4 → v0.85.4)

🐛 v0.84.3 — fixes the prompt-injection false positive

  • fix: use distinct XML marker for threat detection engine errors vs real threats (#49527) — eliminates the false-positive <system> block detection that was blocking label application on every triage run. Reported upstream in github/gh-aw#51782.
  • Fixed false-positive credit-ceiling and timeout detections.

🔒 v0.85.4 — security hardening

  • Expanded secret masking: git invocations, derived secrets in JS runtimes, authHeader values, API-derived OTLP tokens.
  • MCP server secret protection; safe-output artifacts no longer capture base64 CI trigger tokens or raw process logs.
  • Zizmor CI gating on high/critical severity findings.
  • Fixed add_labels silently applying no labels.
  • Retained jobs.*.permissions for built-in safe-outputs and conclusion jobs.
  • Firewall: v0.27.42 → v0.27.44; gh-aw-actions/setup: v0.83.4 → v0.85.4; actions/cache: v5 → v6.1.0; actions/checkout: v6 → v7.0.1.

Label fix

Team:Experience and Team:Ingest are real labels in docs-content and docs-content-internal, and are referenced in their additional-instructions team mappings. They were missing from the safe-outputs add-labels.allowed list, so the triage agent could classify issues correctly but never apply the right team label. Team:SKI is kept — docs-content-internal uses it.

Test plan

  • Trigger /triage on a Kibana/Discover-related issue in docs-content — verify Team:Experience is applied and no false-positive detection fires.
  • Trigger /triage on a Fleet/Beats-related issue — verify Team:Ingest is applied.
  • Trigger /size — verify conclusion job completes cleanly.

🤖 Generated with Claude Code

…ue AWs

The conclusion job in each issue triage/size workflow uses actions/cache/save
to persist daily AIC usage data. Without actions:write the cache save step
silently fails with "cache write denied: token has no writable scopes".

The Team:Experience and Team:Ingest labels were referenced in docs-content's
and docs-content-internal's additional-instructions but were missing from the
safe-outputs allowed list, so the triage agent could never apply them.

Both the .md source files and the compiled .lock.yml files are updated so the
fix takes effect immediately without waiting for the next gh aw compile cycle.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@theletterf
theletterf requested a review from a team as a code owner August 10, 2026 12:48
@theletterf
theletterf requested a review from Mpdreamz August 10, 2026 12:48
@theletterf theletterf self-assigned this Aug 10, 2026
Runs `gh aw upgrade` from v0.83.4 to v0.85.4 across all 14 compiled
workflows. Key changes in this version range relevant to us:

- v0.84.3: fix: use distinct XML marker for threat detection engine errors
  vs real threats — fixes the false-positive prompt-injection detection that
  was blocking label application on issue triage runs (gh-aw#49527)
- v0.85.4: security hardening — expanded secret masking, MCP server secret
  protection, Zizmor CI gating, fixed add_labels silently applying no labels,
  retained jobs.*.permissions for built-in conclusion jobs
- Firewall updated from v0.27.42 → v0.27.44, gh-aw-actions/setup from
  v0.83.4 → v0.85.4, actions/cache from v5 → v6.1.0, actions/checkout
  from v6 → v7.0.1, and other action pins

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@theletterf theletterf changed the title Add actions:write permission and Team:Experience/Ingest labels to issue AWs Upgrade all AWs to v0.85.4; add Team:Experience/Ingest labels to triage Aug 10, 2026
theletterf and others added 2 commits August 10, 2026 15:07
- Update version pin from v0.83.4 → v0.85.4 in scripts/run-gh-aw-compile.sh
  and .github/workflows/pre-commit.yml so the pre-commit compile hook
  regenerates lock files with the same version used to upgrade them
- Add persist-credentials: false to copilot-setup-steps.yml checkout step
  to satisfy zizmor credential-persistence audit
- Add missing EOF newlines to gh-aw-issue-{triage,auto-triage,size}.md

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file is generated by maintenance_workflow.go, not by gh aw compile,
so it was not updated by the earlier gh aw upgrade run. Update it now to
match the v0.85.4 SHAs used by all other workflows.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@theletterf
theletterf enabled auto-merge (squash) August 10, 2026 13:12
theletterf added a commit to elastic/docs-content that referenced this pull request Aug 10, 2026
## Summary

Changes `actions: read` → `actions: write` in `docs-triage.yml` and
`docs-size.yml`.

## Why

The `conclusion` job in the reusable workflows (`gh-aw-issue-triage`,
`gh-aw-issue-size`) calls `actions/cache/save` to persist daily AIC
usage data. A calling workflow can only grant permissions it holds —
currently `actions: read` — so the cache save fails with:

```
cache write denied: token has no writable scopes
```

The reusable workflows in docs-actions are updated to request `actions:
write` in elastic/docs-actions#275.

## Test plan

- [ ] Trigger `/triage` on a test issue — confirm no cache-write error
in the conclusion log.
- [ ] Trigger `/size` on a test issue — same check.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@theletterf
theletterf merged commit 8afd8a3 into main Aug 10, 2026
4 checks passed
@theletterf
theletterf deleted the fix/aw-actions-write-and-team-labels branch August 10, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants