security: remove third-party fastmcp.app fetch from runtime-setup fra… - #1926
Merged
Conversation
…gment The else branch of "Fetch repository conventions" fetched from https://agents-md-generator.fastmcp.app/mcp — a non-Elastic host — and wrote the returned summary verbatim to /tmp/agents.md, which the agent treats as trusted repo policy. A compromise of or MITM against that host would inject instructions into the agent's trusted channel for every adopting repo that lacks an AGENTS.md, with no repo access required by the attacker. The fallback is removed. If no AGENTS.md is present, the step skips gracefully (same behaviour as when the curl failed previously). Note: the compiled lock files need to be regenerated with `make compile`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
big_boom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curlfallback in.github/workflows/gh-aw-fragments/runtime-setup.mdthat fetched repository conventions fromhttps://agents-md-generator.fastmcp.app/mcpwhenAGENTS.mdwas missing.AGENTS.mdexists in the workspace, copy it to/tmp/agents.md; otherwise skip without fetching from any third-party endpoint.Security impact
/tmp/agents.md, which is consumed as repository conventions and propagated into sub-agent prompts.Test plan
make compileand confirm lock files regenerate cleanly.AGENTS.mdpresent (copy path unchanged).AGENTS.mdpresent (step skips cleanly, no external fetch).originally implemented at #1780
The body of this PR is automatically managed by the Trigger Update PR Body workflow.