Add docs drift and gh-aw upgrade - #19
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The gh-aw-upgrade-check workflow breaks the established architecture pattern: it exists only in .github/workflows/ with no source-of-truth copy in gh-agent-workflows/, isn't listed in the architecture tree or READMEs, and won't be managed by make sync. Either add it to gh-agent-workflows/ for consistency (like docs-drift.md), or document why it's an intentional exception.
| @@ -0,0 +1,97 @@ | |||
| --- | |||
There was a problem hiding this comment.
🟡 [MEDIUM] Missing source-of-truth in gh-agent-workflows/
This shim only exists in .github/workflows/ but has no corresponding copy in gh-agent-workflows/. Per the architecture in DEVELOPING.md, source-of-truth shims live in gh-agent-workflows/ and are synced to .github/workflows/ via make sync.
docs-drift.md correctly follows this pattern (exists in both locations), but gh-aw-upgrade-check.md does not. This means make sync won't manage it, and it's excluded from the gh-agent-workflows/ directory tree in DEVELOPING.md.
If this is intentionally internal-only (not for consumer installation), consider either:
- Adding it to
gh-agent-workflows/for consistency with the established sync pattern, or - Documenting the exception (e.g., a comment in the file or in DEVELOPING.md explaining why this shim is
.github/workflows/-only)
| ├── mention-in-pr.md | ||
| ├── mention-in-pr/ | ||
| │ └── rwxp.md | ||
| ├── docs-drift.md # Shim: imports scheduled-report/rwx.md + docs-specific instructions |
There was a problem hiding this comment.
🟡 [MEDIUM] gh-aw-upgrade-check missing from architecture tree
The architecture tree lists docs-drift.md (new in this PR) but omits gh-aw-upgrade-check.md, which is also added in this PR. If gh-aw-upgrade-check is meant to follow the same pattern, it should appear here. If it's intentionally .github/workflows/-only, a note explaining which workflows are internal-only would help future contributors.
| | Issue Triage | New issues | Investigate and provide implementation plans | | ||
| | Mention in Issue | `/ai` command | Answer questions, debug, create PRs | | ||
| | Mention in PR | `/ai` command | Review, fix code, push changes | | ||
| | Docs Drift | Weekday schedule | Detect code changes needing doc updates | |
There was a problem hiding this comment.
⚪ [LOW] gh-aw-upgrade-check not listed in either README
The docs-drift workflow is added to both README.md and gh-agent-workflows/README.md, but gh-aw-upgrade-check is absent from both. If it's meant for consumers, it should be listed here. If internal-only, that's fine but worth noting somewhere.
strawgate
changed the title
1 participant
No description provided.