fix(pr-review): surface missing named-flag values in pr-comment.sh - #1880
Merged
v1v merged 1 commit intoAug 27, 2026
Merged
Conversation
Add explicit parser checks for missing values on --severity, --title, and --why so the script fails with actionable errors instead of a silent shift failure. Also add regression tests covering omitted values and flag-as-value cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
v1v
approved these changes
Aug 27, 2026
v1v
marked this pull request as ready for review
August 27, 2026 09:19
github-actions
Bot
added
the
small_boom
v1v
deleted the
fix-1879-pr-comment-missing-value-errors-02f0efde42edad5a
branch
August 27, 2026 11:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--severity,--title, and--whyduring argument parsing inclaude-workflows/pr-review/scripts/pr-comment.shtests/test_pr_comment_arg_validation.pyregression coverage for omitted values and flag-as-value casesCloses #1879.
Validation
UV_CACHE_DIR=/tmp/gh-aw/agent/uv-cache uv run --extra test pytest tests/test_pr_comment_arg_validation.py -vWhat is this? | From workflow: Trigger Bug Hunter
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.