Skip to content

[text-auditor] Fix two misleading PR/dispatch user-facing script messages #855

Description

@github-actions

Text Improvements

The following user-facing text issues were found in the repository. Each is a low-effort fix.

1. Dispatch summary can overstate success when failures occurred

File: scripts/trigger-ci-workflows.sh (line 144)
Current text: Dispatched $total workflows across \$\\{\#CATEGORIES[@]} categories.
Suggested fix: Attempted to dispatch $total workflows across \$\\{\#CATEGORIES[@]} categories.
Why: The script prints per-workflow failures (✗ ... (dispatch failed) at line 128), but the final summary reads as full success. This can mislead users reviewing output.

2. PR diff error message states the wrong cause when patch data is absent

File: claude-workflows/pr-review/scripts/pr-diff.sh (line 117)
Current text: Error: File '\$\{FILE}' not found in PR diff
Suggested fix: Error: File '\$\{FILE}' not found in PR diff, or no patch data is available (binary/too large).
Why: In this script, an empty .patch triggers the same branch, so the file may exist in the PR while still showing "not found." This is a direct clarity/misleading-text issue.

Completeness pass

  • Pattern not found in PR diff: 2 matches were verified.
    • pr-diff.sh line 117 is misleading (no separate no-patch handling).
    • pr-comment.sh line 148 is not included because it has a separate explicit no-patch error at line 158.
  • Dispatch-summary overstatement pattern: verified in scripts/trigger-ci-workflows.sh line 144.

Suggested Actions

  • Update scripts/trigger-ci-workflows.sh summary wording to avoid implying successful dispatch for all workflows when failures may have occurred.
  • Update claude-workflows/pr-review/scripts/pr-diff.sh error wording (or branching) so the message distinguishes "file not in diff" from "patch unavailable".

What is this? | From workflow: Trigger Text Auditor

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

  • expires on Apr 8, 2026, 1:48 PM UTC

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions