noop for https://github.com/elastic/beats/pull/49327#issuecomment-4026109034

[v1v]

elastic/beats#49327 (comment) was created even though there were no failures

stop reporting with a comment if no failures to be reported

[github-actions]

This issue looks like a duplicate of #605 and may be safe to close.

Possible duplicates:

• Noop on no failure #605 — It reports the same no-failure behavior where a detective comment is still posted, and asks for noop behavior instead.

2 related issues

• PR actions detective no-op if no failures #620 — It documents the same behavior pattern and prior triage context around no-failure detective comments.
• Disable no-op runs for duplicate issues workflow #255 — It captures prior no-op reporting decisions for this workflow family, which helps with consistency expectations.

---

What is this? | From workflow: Trigger Duplicate Issue Detector

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[github-actions]

tl;dr: The no-failure noop behavior is already implemented in elastic/ai-github-actions, but the linked elastic/beats trigger runs detective on all completed runs (including success), so this issue is best handled as downstream trigger drift; I recommend closing as duplicate of #605 and patching Beats trigger guard.

Recommendation

Close this issue as duplicate/same scope as #605, and apply a downstream fix in elastic/beats to only invoke PR Actions Detective for failed runs.

If we want defense in depth in this repo, open a separate hardening issue to enforce no-failure behavior at runtime (not only via prompt guidance).

Findings

• ai-github-actions already has a failure gate in trigger/workflow examples:

  • .github/workflows/trigger-pr-actions-detective.yml:17-20
  • gh-agent-workflows/pr-actions-detective/example.yml:15-20

• The detective prompt and compiled lock explicitly instruct noop when no jobs failed:

  • .github/workflows/gh-aw-pr-actions-detective.md:110
  • .github/workflows/gh-aw-pr-actions-detective.lock.yml:333
  • gh-agent-workflows/pr-actions-detective/README.md:35-36

• Related history confirms prior fix landed:

  • PR #609 (merged) carried the no-failure noop updates from #606.

• The linked external workflow (elastic/beats) currently has no failure if guard and always calls detective:

  • elastic/beats/.github/workflows/trigger-pr-actions-detective.yml lines 13-15 (raw file), where job run directly uses the detective workflow.

• The linked PR comment thread includes detective comments on successful runs (e.g., “completed successfully, so there is no failing job to diagnose”), matching the reported noise behavior.

Verification

I verified local repo behavior with:

nl -ba .github/workflows/trigger-pr-actions-detective.yml | sed -n '13,22p'
nl -ba .github/workflows/gh-aw-pr-actions-detective.md | sed -n '102,112p'
nl -ba .github/workflows/gh-aw-pr-actions-detective.lock.yml | sed -n '325,336p'
nl -ba gh-agent-workflows/pr-actions-detective/README.md | sed -n '32,38p'

Observed output shows:

• trigger is failure-gated in this repo,
• prompt/lock contain explicit no-failure noop instruction,
• README documents no-failure noop behavior.

I also fetched the downstream file:

• https://raw.githubusercontent.com/elastic/beats/main/.github/workflows/trigger-pr-actions-detective.yml

It lacks the if: github.event.workflow_run.conclusion == 'failure' guard.

Detailed Action Plan

1. In elastic/beats/.github/workflows/trigger-pr-actions-detective.yml, add the same guard used upstream:

jobs:
  run:
    if: >-
      github.event.workflow_run.conclusion == 'failure' &&
      toJSON(github.event.workflow_run.pull_requests) != '[]'
    uses: elastic/ai-github-actions/.github/workflows/gh-aw-pr-actions-detective.lock.yml@v0

2. Validate in Beats:

• successful workflow run -> detective should not run/comment,
• failing workflow run tied to PR -> detective should run and comment.

3. (Optional hardening follow-up in this repo)

• Add runtime guard in detective workflow path so non-failure runs cannot emit add-comment even if prompt-following drifts.
• Candidate files for follow-up: .github/workflows/gh-aw-pr-actions-detective.md and compiled .lock.yml behavior around safe-output handling.

Related Items

Type	Link	Relevance
Issue	#605	Same no-failure/no-op scope, still open
Issue	#620	Same topic; closed after merged fix
PR	#609	Merged no-failure noop prompt/docs updates
PR	#606	Earlier implementation attempt for same fix
File	.github/workflows/trigger-pr-actions-detective.yml:17-20	Upstream failure-only guard
File	.github/workflows/gh-aw-pr-actions-detective.md:110	Explicit no-failure noop instruction
File	.github/workflows/gh-aw-pr-actions-detective.lock.yml:333	Compiled noop instruction
File	gh-agent-workflows/pr-actions-detective/README.md:35-36	Documented noop behavior
External file	https://raw.githubusercontent.com/elastic/beats/main/.github/workflows/trigger-pr-actions-detective.yml	Downstream trigger drift (missing failure guard)

---

What is this? | From workflow: Trigger Issue Triage

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.