[product-manager-impersonator] Lint dogfood-with.yml overrides against workflow inputs #619

Feature Idea

Summary: Add a lint check that validates every gh-agent-workflows/*/dogfood-with.yml key against the corresponding workflow’s declared workflow_call inputs before trigger generation.

Why a Customer Would Want This

Maintainers rely on dogfood overrides to test workflows in this repo, and a typo in override keys can silently produce incorrect trigger behavior until much later in CI/runtime. A fast, local validation step reduces debugging time and makes workflow authoring safer.

Rough Implementation Sketch

• Add scripts/check-dogfood-overrides.py to map each gh-agent-workflows/(name)/dogfood-with.yml to .github/workflows/gh-aw-(name).md and validate override keys against declared workflow_call.inputs.
• Add lint-dogfood-overrides to Makefile and include it in make lint.
• Emit actionable failures (workflow, unknown key, optional close-match suggestion).
• Document the new lint step in gh-agent-workflows/DEVELOPING.md near the dogfood override section.

Why It Won't Be That Hard

The mapping is already deterministic by naming convention, and the existing toolchain already has script-based lint checks wired via make lint; this is an additive guardrail with a small implementation surface.

Evidence

• scripts/dogfood.sh injects dogfood-with.yml into generated triggers (scripts/dogfood.sh#L76-L93) but does not validate whether override keys are valid workflow inputs.
• Dogfood override behavior is documented as raw key/value injection (gh-agent-workflows/DEVELOPING.md#L210-L221), which increases typo risk without schema checks.
• Current lint pipeline validates workflows/actions/nav, but not dogfood override schema correctness (Makefile#L197-L210, Makefile#L236-L237; .github/workflows/ci.yml#L9-L53).
• Recent activity shows strong emphasis on workflow reliability and correctness (merged PRs Fix target fallback expression parsing in compiled workflows #610, Add reusable action to detect conflicted open PRs #611, Add include/exclude label filters to conflicted PR action #612, Filter conflicted PRs by author association to exclude external contributors #613, Tighten pr-review-addresser summary: concise output with collapsed test results #614, Fix workflow_call checkout for target PR branch #615, Use gh-aw build 1508133d7 and recompile update-pr-body #616), so this is aligned and timely.
• Duplicate check: no open issue matched dogfood-with.yml override key validation via searches for dogfood-with.yml, lint dogfood, and override validation; prior PM impersonator issues ([product-manager-impersonator] Add --ref targeting to quick setup #409, [product-manager-impersonator] Add --audit preflight mode to quick setup #523, [product-manager-impersonator] Auto-detect git remote in quick setup #562, [product-manager-impersonator] Add make verify-generated pre-push drift check #570, [product-manager-impersonator] Make quick setup token prompt work in piped install #577, etc.) cover different areas.

What is this? | From workflow: Trigger Product Manager Impersonator

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.