Skip to content

feat: add just#171

Merged
wdconinc merged 5 commits intomasterfrom
pr/add_just
Mar 1, 2026
Merged

feat: add just#171
wdconinc merged 5 commits intomasterfrom
pr/add_just

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Feb 18, 2026

It appears, there is some demand for a tool to run common tools. My proposal is to follow what LDMX experiment did and adopt just. We can add justfiles to the relevant repositories.

Copilot AI review requested due to automatic review settings February 18, 2026 16:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the "just" command runner tool to the Spack package preferences. "Just" is a command runner similar to make that can be used to define and execute common development tasks, following the pattern established by the LDMX experiment.

Changes:

  • Added package preferences for "just" version 1.46.0 in spack-environment/packages.yaml

Comment thread spack-environment/packages.yaml
Comment thread spack-environment/packages.yaml
@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Feb 18, 2026

I think, this has rust in build closure. @wdconinc, please remind me, are we averse to that?

Copilot AI review requested due to automatic review settings February 18, 2026 16:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comment thread containers/eic/profile.d/z22_just.sh Outdated
@wdconinc
Copy link
Copy Markdown
Contributor

I think, this has rust in build closure. @wdconinc, please remind me, are we averse to that?

We already have cryptography in rust. I don't have anything against rust.

Copilot AI review requested due to automatic review settings March 1, 2026 16:02
@wdconinc wdconinc enabled auto-merge (squash) March 1, 2026 16:04
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this just in.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@wdconinc wdconinc merged commit ab1f2ef into master Mar 1, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants