java 11 compatibility: handle a new exception if a field is inaccessible#59
Closed
sda399 wants to merge 5 commits intoehcache:masterfrom
Closed
java 11 compatibility: handle a new exception if a field is inaccessible#59sda399 wants to merge 5 commits intoehcache:masterfrom
sda399 wants to merge 5 commits intoehcache:masterfrom
Conversation
sda399
commented
Sep 20, 2019
sda399
commented
- setAccessible function now throws a new exception
- catch the new exception class that appeared in java9+ only
- setAccessible function now throws a new exception - catch the new exception class that appeared in java9+ only
Author
|
Hi all, |
chrisdennis
requested changes
Sep 24, 2019
Contributor
|
@chrisdennis would it be possible to merge this please? The library doesn't really work well with java 11 without this change and as far as i can tell all the issues have been fixed. I'd be more than happy to assist if any more changes are required |
| } catch (RuntimeException e) { | ||
| // new class (jdk9+ only) can be thrown | ||
| if ("java.lang.reflect.InaccessibleObjectException".equals(e.getClass().getName())) { | ||
| LOG.error("JPMS blocks field access. This prevents Ehcache from accessing " |
Contributor
There was a problem hiding this comment.
This should probably be just a warning. Because it might occur a lot and there's nothing we can do about it.
chrisdennis
requested changes
Sep 18, 2020
| LOG.error("Security settings prevent Ehcache from accessing the subgraph beneath '{}'" + | ||
| " - cache sizes may be underestimated as a result", field, e); | ||
| continue; | ||
| } catch (RuntimeException e) { |
Member
There was a problem hiding this comment.
Right now this is swallowing thrown RuntimeException instances without logging anything and then adding an inaccessible field to the collection. I think it's going to be simpler (and cleaner) to just:
} catch (RuntimeException e) {
LOG.warn("The JVM is preventing Ehcache from accessing the subgraph beneath '{}'" +
" - cache sizes may be underestimated as a result", field, e);
}
Contributor
|
Unfortunately i do not have access to the original for had to re-fork and re-raise the pr, available here #61 |
Member
|
Replaced with #61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.