feat: adds support for workspace protocol#46
Open
EdRW wants to merge 1 commit into
Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Author
|
Just wanted to add that this change doesn't add support for NPM workspaces, since NPM doesn't use the Unfortunately this change won't resolve this issue. Info about NPM workspaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, dependencies that live in another package within a monorepo workspace get treated as external, which causes a error.
This change adds support for monorepos using the
workspace:protocol by treating workspace packages as notExternal.This is done by checking the package.json for dependencies that are referenced using
workspace:protocole.g.
"foo": "workspace:*",and adding them to the
notExternalarray that is passed to theexternalPlugin.Info about workspaces