Skip to content

Escape values in --dry-run curl preview to prevent shell injection #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brodkin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape values in --dry-run curl preview to prevent shell injection #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/lib/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,29 @@ function info(msg) {
process.stderr.write(msg + '\n');
}

/**
* Quote a value as a single-quoted POSIX shell word. An embedded single
* quote is closed, escaped, and reopened ('\'') so the value cannot end the
* quoting. Without this, a value that contains a quote (for example an
* Egnyte path with an apostrophe) breaks out of the quoted string in the
* previewed curl command, and a crafted path can inject arbitrary commands.
*/
function shellQuote(value) {
return "'" + String(value).replace(/'/g, "'\\''") + "'";
}

function formatDryRun(opts) {
const { method, url, body, bodyType, localFile } = opts;
const parts = [
"curl -X " + method + " '" + url + "'",
'curl -X ' + method + ' ' + shellQuote(url),
" -H 'Authorization: ***'",
];
if (bodyType === 'json') {
parts.push(" -H 'Content-Type: application/json'");
parts.push(" -d '" + JSON.stringify(body) + "'");
parts.push(' -d ' + shellQuote(JSON.stringify(body)));
} else if (bodyType === 'multipart') {
parts.push(" -H 'Content-Type: multipart/form-data'");
parts.push(" -F 'file=@" + localFile + "'");
parts.push(' -F ' + shellQuote('file=@' + localFile));
}
return parts.join(' \\\n');
}
Expand Down Expand Up @@ -113,4 +124,4 @@ function serializeError(err) {
return payload;
}

module.exports = { CLIError, out, fatal, info, formatDryRun, printDryRun, requireConfirmation, serializeError };
module.exports = { CLIError, out, fatal, info, shellQuote, formatDryRun, printDryRun, requireConfirmation, serializeError };