Repository navigation
fix(ci): isolate package verification environment exports - #289
Merged
Merged
Conversation
Redirect build-time GitHub environment exports to /dev/null in STJM packaging and trimming verification, matching the existing test-job isolation. Temporary consumer builds can emit multiline version data which GitHub rejects even when package checks succeed. Keep package creation and all analyzer, trimming and NativeAOT checks enabled.
egil
added a commit
that referenced
this pull request
Oct 6, 2026
Remove the independent STJM workflow change from the OM upgrade diff. Preserve the CI repair on its own branch and PR #289 so it can be reviewed and merged independently.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow change consistently isolates affected builds without altering verification coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Isolates STJM package verification from malformed build-time GitHub environment exports.
Changes:
- Discards environment exports during package/analyzer verification.
- Applies the same isolation to trimming and NativeAOT checks.
| File | Description |
|---|---|
.github/workflows/egil-systemtextjson-migration-ci.yml |
Redirects nested-build environment exports to /dev/null. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the CI-only repair out of OM PR #286. Temporary consumer builds can emit multiline version data which GitHub rejects after otherwise successful verification. Match the environment isolation already used by the test jobs.
Evidence
Unable to process file command envandInvalid format -alpha+663145f581.Merge Danger
Door: Two-way; workflow-only and straightforward to revert.
Blast Radius: CI.
No package API or runtime changes. OM PR #286 needs this repair on main to avoid the independent STJM CI failure after removing it from the OM diff. Do not merge or release automatically.